Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/always use asgard pydantic models #87

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Mar 21, 2019

No description provided.

daltonmatos added 5 commits Mar 21, 2019
@daltonmatos daltonmatos requested a review from diogommartins as a code owner Mar 21, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #87 into feature/stop-using-hollowman-db-url will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@                          Coverage Diff                          @@
##           feature/stop-using-hollowman-db-url    #87      +/-   ##
=====================================================================
+ Coverage                                94.97%    95%   +0.03%     
=====================================================================
  Files                                       79     79              
  Lines                                     2008   2022      +14     
=====================================================================
+ Hits                                      1907   1921      +14     
  Misses                                     101    101
Impacted Files Coverage Δ
asgard/http/auth/auth_required.py 96.7% <100%> (ø) ⬆️
asgard/models/user.py 100% <100%> (ø) ⬆️
asgard/backends/users.py 100% <100%> (ø) ⬆️
asgard/models/account.py 100% <100%> (ø) ⬆️
asgard/models/base.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448a0a2...eb16229. Read the comment docs.

@daltonmatos daltonmatos merged commit eb16229 into feature/stop-using-hollowman-db-url Mar 21, 2019
3 checks passed
3 checks passed
ci/circleci: test Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 94.97%)
Details
codecov/project 95% (+0.03%) compared to 448a0a2
Details
@daltonmatos daltonmatos deleted the feature/always-use-asgard-pydantic-models branch Mar 22, 2019
@daltonmatos daltonmatos added this to the 0.82.0 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.