Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/expose app cpu ram stats #96

Merged
merged 21 commits into from Apr 8, 2019
Merged

Conversation

@daltonmatos
Copy link
Member

daltonmatos commented Mar 29, 2019

Closes #78

daltonmatos added 6 commits Mar 26, 2019
Trocamos o termo `Backend` por `Orchestrator` que reflete melhor o papel
desse objeto. É o orchestrator quem fala com os backends, seja o backend
de Apps ou o backend de Agents.

Mudei a assinatura de alguns métodos para não mais receber strings como
parametros e passa a receber objetos.
Não precisamos mais do rebuild_schema(), nem do ContextStub.
O teste valida apenas que, dado um resultado com agregações,
conseguimos fazer o parsing e construir um objeto `AppStats` para ser
retornado.
Esse endpoint retorna o uso de cpu e ram de uma app na última 1h.
@daltonmatos daltonmatos requested a review from diogommartins as a code owner Mar 29, 2019
daltonmatos added 3 commits Mar 29, 2019
A porta é escolhida pela env TEST_ASYNCWORKER_HTTP_PORT.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 1, 2019

Codecov Report

Merging #96 into master will increase coverage by 0.2%.
The diff coverage is 96.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #96     +/-   ##
=========================================
+ Coverage      95%   95.21%   +0.2%     
=========================================
  Files          79       82      +3     
  Lines        2022     2131    +109     
=========================================
+ Hits         1921     2029    +108     
- Misses        101      102      +1
Impacted Files Coverage Δ
asgard/backends/mesos/models/agent.py 100% <ø> (+2%) ⬆️
asgard/backends/mesos/models/app.py 100% <ø> (ø) ⬆️
asgard/models/agent.py 88.23% <ø> (+4.02%) ⬆️
asgard/handlers/http.py 0% <0%> (ø) ⬆️
asgard/services/agents.py 100% <100%> (ø) ⬆️
asgard/backends/marathon/impl.py 100% <100%> (ø)
asgard/api/resources/apps.py 100% <100%> (ø) ⬆️
asgard/api/agents.py 81.81% <100%> (+2.4%) ⬆️
asgard/backends/mesos/impl.py 100% <100%> (+2.08%) ⬆️
asgard/api/apps.py 100% <100%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 962b2b4...f479827. Read the comment docs.

daltonmatos added 5 commits Apr 1, 2019
Assim podemos usar qualuqer python3, que é o que está especificado no
Pipfile
@daltonmatos daltonmatos force-pushed the feature/expose-app-cpu-ram-stats branch from 98e6b3e to b271103 Apr 1, 2019
daltonmatos added 3 commits Apr 1, 2019
@daltonmatos daltonmatos force-pushed the feature/expose-app-cpu-ram-stats branch 3 times, most recently from 0a31c4c to a655ed3 Apr 3, 2019
@daltonmatos daltonmatos force-pushed the feature/expose-app-cpu-ram-stats branch from a655ed3 to 1305fba Apr 3, 2019
daltonmatos added 3 commits Apr 3, 2019
o Erro que tiver ocorrido é colocado no campo `errors` da resposta.
@daltonmatos daltonmatos merged commit f479827 into master Apr 8, 2019
4 of 5 checks passed
4 of 5 checks passed
ci/circleci: py37x Your tests failed on CircleCI
Details
ci/circleci: py368 Your tests passed on CircleCI!
Details
ci/circleci: py36x Your tests passed on CircleCI!
Details
codecov/patch 96.81% of diff hit (target 95%)
Details
codecov/project 95.21% (+0.2%) compared to 962b2b4
Details
@daltonmatos daltonmatos deleted the feature/expose-app-cpu-ram-stats branch May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.