arcsinh, arcosh and arctanh are not implemented #1

Open
b45ch1 opened this Issue Jun 4, 2009 · 3 comments

Comments

Projects
None yet
2 participants
Owner

b45ch1 commented Jun 4, 2009

No description provided.

Contributor

roryyorke commented Aug 2, 2009

These don't even work with plain ADOL-C on my Ubuntu 9.04 system. asinh etc are defined the std::tr1 namespace, but ADOL-C 2.1.0 doesn't use that. A solution would be to have:

#include <cmath>
#include <tr1/cmath>

namespace adolc_math {
  using namespace std;
  using namespace std::tr1;
}

and then defining ADOLC_MATH_NSP to be adolc_math.

The change to pyadolc would then be quite simple.

Owner

b45ch1 commented Aug 3, 2009

good idea.
I think the easiest way to proceed is to fork ADOL-C 2.1.0, change the code as you have stated, recommend the forked ADOL-C for PYADOLC and wait until the changes are incorporated in the official ADOL-C repository (ADOL-C 2.2.0?).

What do you think?

Contributor

roryyorke commented Aug 3, 2009

I've got most of the way there; there's a macro
here
that checks for the headers. I've put this into configure.ac, and
after a bit of updating of header files, I managed to build ADOL-C.

I have to manually define ATRIG_ERF in usrparms.h; it seems to me that
configure should magically take care of it. I'll post a message to
the ADOL-C list and ask for advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment