Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix missing selector for 10.6 or earlier #16

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

splhack commented Jul 21, 2011

Hi,

I created a patch for missing selector of 10.6 or earlier. lion branch with Deployment Target=10.6 works fine on 10.6.

Owner

b4winckler commented Jul 21, 2011

Thanks for the patch. However, I believe the correct fix is to only use these APIs if building for 10.7 or higher, so I pushed another fix instead.

@b4winckler b4winckler closed this Jul 21, 2011

Contributor

splhack commented Jul 21, 2011

I think the lion branch can be build for 10.7, 10.6 or earlier if you use MACOSX_DEPLOYMENT_TARGET with 10.7 SDK. However your fix means that Lion fullscreen feature is only activated with MACOSX_DEPLOYMENT_TARGET=10.7. It doesn't work on 10.6. My fix is, for example, MACOSX_DEPLOYMENT_TARGET=10.6 and if that binary works on 10.7, Lion fullscreen feature is activated, and on 10.6, the former fullscreen feature is activated as well. How about it?

Owner

b4winckler commented Jul 21, 2011

The patch I pushed does what I initially intended it to, but I admit that I did not consider your point. I will most likely be rewriting the full screen code so that one can toggle between Lion's and MacVim's full screen code at runtime. At this point I will make it work the way you suggest. For now I'll let it be though.

Thanks for pointing this out to me.

Contributor

splhack commented Jul 21, 2011

Thank you so much I really appreciate your work!

jtaby pushed a commit to jtaby/macvim that referenced this pull request Jul 26, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment