Suppress warnings on OS X 10.5 when compiling makeicns utility #25

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

xoob commented Feb 29, 2012

A few NSFileManager and CG methods were deprecated in OS X v10.5 and are
now causing warnings during compilation. Because of this the custom
icons have been made optional and the default build does not provide
them anymore.

This is a workaround fix to suppress the warning messages until the
source code is updated properly.

Suppress warnings when compiling makeicns utility
A few NSFileManager and CG methods were deprecated in OS X v10.5 and are
now causing warnings during compilation. Because of this the custom
icons have been made optional and the default build does not provide
them anymore.

This is a workaround fix to suppress the warning messages until the
source code is updated properly.
Owner

b4winckler commented Feb 29, 2012

Thanks for the patch. I would much rather have a patch that actually fixes the problem however -- I don't really see the purpose in adding a flag to suppress warnings.

Note that custom icons were not made optional because of warnings -- it was because they relied on an internet connection and for the site that hosts the Envy Code R font to be up (it did happen to be unreachable every now and then).

(Also: I am not the author of the makeicns utility so I was hoping somebody else would eventually fix this script.)

@b4winckler b4winckler closed this Feb 29, 2012

peteschaffner referenced this pull request in peteschaffner/macvim Jul 18, 2012

Merge pull request #25 from jballanc/split-browser
Accomodate alternate keyboard layouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment