Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

2x assets for the "new tab", "close tab", "tab overflow" buttons #28

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

nico commented Jul 22, 2012

No description provided.

Owner

b4winckler commented Jul 22, 2012

Is this all the patching that is needed to get the 2x images to show on a hidpi display?

Contributor

nico commented Jul 22, 2012

Yes.

Owner

b4winckler commented Jul 22, 2012

OK.

I'm a bit worried about the comment "cribbed from Terminal.app". Does that mean you've included assets taken from Terminal.app? If so, I have to ask if you are 100% certain that these images are released under a license that lets us use them? If not, I am not comfortable with merging this patch unfortunately.

Contributor

nico commented Jul 23, 2012

Fair enough. I replaced the images with images drawn by https://gist.github.com/3161796 (which I just wrote).

Owner

b4winckler commented Jul 23, 2012

Thank you. I'll try to merge this tonight.

Contributor

nico commented Jul 23, 2012

I rebased this patch so that the assets from Terminal.app don't make it to your repo, even if only for one commit.

Contributor

nico commented Jul 23, 2012

I also added a 2x asset of the overflow chevron.

Owner

b4winckler commented Jul 23, 2012

Thanks! I've (squashed and) merged now.

@b4winckler b4winckler closed this Jul 23, 2012

Contributor

nico commented Jul 23, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment