Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app and document icon for Yosemite #44

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
@jasonlong
Copy link

jasonlong commented Aug 24, 2014

Download the .icns file (Update: this is the updated version from below)

This is the icon I proposed in #41. I have created a new .icns file with slightly tweaked versions at 512@2x, 256@2x, and 128@2x. Smaller versions will scale down using the 128@2x version.

This is the 128@2x version:

icon_128x128 2x

I also updated the document icon.

Before:

macvim-generic-old

After:

icon_512x512 2x

@jasonlong jasonlong referenced this pull request Aug 24, 2014

Closed

New icon #41

@leonardt

This comment has been minimized.

Copy link

leonardt commented Aug 24, 2014

👍

@agsdot

This comment has been minimized.

Copy link

agsdot commented Aug 24, 2014

Nice!

@oleyb

This comment has been minimized.

Copy link

oleyb commented Aug 25, 2014

This is sooo good.

@DomT4

This comment has been minimized.

Copy link

DomT4 commented Aug 25, 2014

I commented on the other thread too, but a 👍 from me. It looks great alongside the other Yosemite icons. Hope this one gets merged.

@EduardoBautista

This comment has been minimized.

Copy link

EduardoBautista commented Aug 25, 2014

👍

2 similar comments
@khzaw

This comment has been minimized.

Copy link

khzaw commented Aug 25, 2014

👍

@caiogondim

This comment has been minimized.

Copy link

caiogondim commented Aug 25, 2014

👍

@bruno-

This comment has been minimized.

Copy link

bruno- commented Aug 25, 2014

Really nice 👍

@joshhartigan

This comment has been minimized.

Copy link

joshhartigan commented Aug 25, 2014

👍

6 similar comments
@jaxbot

This comment has been minimized.

Copy link

jaxbot commented Aug 25, 2014

👍

@jojoyuji

This comment has been minimized.

Copy link

jojoyuji commented Aug 25, 2014

👍

@porada

This comment has been minimized.

Copy link

porada commented Aug 25, 2014

👍

@divanvisagie

This comment has been minimized.

Copy link

divanvisagie commented Aug 25, 2014

👍

@zenangst

This comment has been minimized.

Copy link

zenangst commented Aug 25, 2014

👍

@bolasblack

This comment has been minimized.

Copy link

bolasblack commented Aug 25, 2014

👍

@natw

This comment has been minimized.

Copy link

natw commented Aug 25, 2014

I'm not loving the low contrast. The V, especially in the upper left, starts to fade into the background. It's certainly more Yosemite-ish, and probably even better looking, but not nearly as iconic.

@rricard

This comment has been minimized.

Copy link

rricard commented Aug 25, 2014

👍

2 similar comments
@fatih

This comment has been minimized.

Copy link

fatih commented Aug 25, 2014

👍

@evantravers

This comment has been minimized.

Copy link

evantravers commented Aug 25, 2014

👍

@jojoyuji

This comment has been minimized.

Copy link

jojoyuji commented Aug 25, 2014

@natw I disagree, it fits perfectly in my yosemite context. Contrast is good too :)

zenangst added a commit to zenangst/macvim that referenced this pull request Aug 25, 2014

@mdznr

This comment has been minimized.

Copy link

mdznr commented Aug 25, 2014

The shadow is a bit wonky. It's not soft and is just offset vertically. This won't work super well alongside other app icons. The shadow form the 'V' can be sharper against the diamond, but not against the background.

The styling of the shapes (inner shadows) feels strange and would work better if removed, especially when the icon is scaled down.

The serifs on the 'V' shape are extremely rounded, creating a fully rounded end-cap, which is highly unusually for a typeface and distracting because of it.

If you're using a green color close enough to the ones used on Apple's own iOS and OS X apps, just use the same exact color(s), otherwise it creates inconsistency and dissonance.

The icon I've proposed in #43 solves some of these issues. I started working on that icon before even realizing there were discussions about it.

Shown below is the 128x128 version of the icon I've proposed.
icon_128x128

@jasonlong

This comment has been minimized.

Copy link
Author

jasonlong commented Aug 25, 2014

@mdznr I have to say I disagree with most of this. The shadows are cast vertically because the light source of Yosemite icons is directly above. The inner and outer shadows here match up very close to the reference Yosemite icons I have, as do the gradients. I've tweaked the shadows at the smaller sizes in my .icns. And I definitely don't agree with using the exact same green that Apple is using for their icons.

@mdznr

This comment has been minimized.

Copy link

mdznr commented Aug 25, 2014

@jasonlong

Sorry, I should've been more clear. Yes, the shadow will still cast down vertically, but it should be blurred more. Right now it is very sharp (not a lot of depth between the shape and the background). This is not how the other app icons (especially Apple's) are.

The inner shadows are several pixels thick and are very dark and very light. This is not how they appear on the Yosemite icons.
screen shot 2014-08-25 at 4 19 08 pm

Not every icon needs to be limited to the small color palette, yes. However, the green shown above is treading too close to the standard green Apple is using. If you don't wish to use that green, move further away from it, otherwise it looks and feels like a mismatch and not a deliberate choice.

@jasonlong

This comment has been minimized.

Copy link
Author

jasonlong commented Aug 26, 2014

Ok, I took a closer look at the shadows and made some tweaks. I think these are looking better do indeed match the reference icons better.

icon_256x256

icon_128x128 2x

I still don't buy the green argument (and I'm pretty fond of this color). There are going to be a zillion green app icons all over the spectrum, including shades of light green. I don't believe that there should be some value where icon colors should "snap" to Apple's lime green.

@ghost

This comment has been minimized.

Copy link

ghost commented Aug 26, 2014

awesomesauce 👍

@fgr0

This comment has been minimized.

Copy link

fgr0 commented Aug 26, 2014

Awesome icon! I just wanted to ask, if someone could also generate the custom-filetype-icons using this design. The scripts to generate them haven't worked for me since Mountain Lion :(

krid78 pushed a commit to krid78/macvim that referenced this pull request Jan 12, 2015

Daniel Kriesten
change iconset to a flat one
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

Signed-off-by: Daniel Kriesten <krid@tu-chemnitz.eu>
@shaond

This comment has been minimized.

Copy link

shaond commented Jan 22, 2015

Folks, @jocelynmallon has done a fine job of merging all these pull requests and documented how to install it on her blog: https://girlintroverted.wordpress.com/2014/11/06/macvim-for-yosemite/

It's worth checking out. Kudos go to @jocelynmallon (you rock!).

update_app_and_document_icon_for_yosemite_by_jasonlong_ pull_request__44 _b4winckler_macvim

@gglanzani

This comment has been minimized.

Copy link

gglanzani commented Jan 22, 2015

@shaond 👍

Great work @jocelynmallon

@eirnym

This comment has been minimized.

Copy link

eirnym commented Jan 23, 2015

👍 I like this icon

krid78 pushed a commit to krid78/macvim that referenced this pull request Feb 1, 2015

Daniel Kriesten
change iconset to a flat one
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

Signed-off-by: Daniel Kriesten <krid@tu-chemnitz.eu>
@ViViDboarder

This comment has been minimized.

Copy link

ViViDboarder commented Mar 13, 2015

@jasonlong did you submit this via mailing list? I'm not sure that @b4winckler monitors this repo here. Maybe soon now that Google Code is shutting down.

@simono

This comment has been minimized.

Copy link

simono commented Mar 13, 2015

@jasonlong

This comment has been minimized.

Copy link
Author

jasonlong commented Mar 13, 2015

Thanks for the heads-up @simono. I'll submit a PR over on @macvim-dev's repo.

@simono simono referenced this pull request Mar 13, 2015

Closed

Refactor/adapt to yosemite #45

2 of 4 tasks complete

krid78 pushed a commit to krid78/macvim that referenced this pull request Apr 2, 2015

Daniel Kriesten
change iconset to a flat one
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Apr 17, 2015

Daniel Kriesten
change iconset to a flat one
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.
@ghecho

This comment has been minimized.

Copy link

ghecho commented Apr 29, 2015

👍

krid78 pushed a commit to krid78/macvim that referenced this pull request May 6, 2015

Daniel Kriesten
change iconset to a flat one
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.
@johnstephens

This comment has been minimized.

Copy link

johnstephens commented May 15, 2015

I love it! What a delightful surprise when I ran brew upgrade today.

krid78 pushed a commit to krid78/macvim that referenced this pull request May 21, 2015

Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Jun 26, 2015

Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.
@jtheoof

This comment has been minimized.

Copy link

jtheoof commented Jul 13, 2015

Yeah, @johnstephens is right! So the new icon is there, but the MR is still opened. What kind of magic happened here?

@simono

This comment has been minimized.

Copy link

simono commented Jul 14, 2015

krid78 pushed a commit to krid78/macvim that referenced this pull request Jul 28, 2015

Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Aug 3, 2015

Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.
@jasonlong

This comment has been minimized.

Copy link
Author

jasonlong commented Aug 6, 2015

Going to close this. For those interested, the icon is now available in https://github.com/macvim-dev/macvim which is what homebrew uses now.

@jasonlong jasonlong closed this Aug 6, 2015

krid78 pushed a commit to krid78/macvim that referenced this pull request Aug 26, 2015

Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Sep 5, 2015

Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Oct 4, 2015

Daniel Kriesten Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Nov 3, 2015

Daniel Kriesten Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

krid78 pushed a commit to krid78/macvim that referenced this pull request Nov 21, 2015

Daniel Kriesten Daniel Kriesten
[fix] use smooth icon (again)
I found the icon set via b4winckler#44

There are two blog posts from the (original?) author:
https://girlintroverted.wordpress.com/2014/08/15/filedoc-icons-for-macvim/
https://girlintroverted.wordpress.com/2014/08/26/macvim-doc-icons-redux-howto/

But yet, I simply cpoied the icons directly into the icns dir.

@jasonlong jasonlong deleted the jasonlong:yosemite-icon branch Feb 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.