Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/adapt to yosemite #45

Closed
wants to merge 30 commits into from

Conversation

Projects
None yet
@zenangst
Copy link

zenangst commented Sep 11, 2014

I've added a new tab style that conforms with the new look in Yosemite.

I was wondering what you guys think of it so far?

On my todo list so far:

  • Change the way the close button looks and behaves
  • Change tab bar height
  • Change the "New Tab" icon on the right side
  • Change font color depending on tab state - zenangst@67fb6e6

screen shot 2014-09-14 at 11 06 35

zenangst added some commits Aug 25, 2014

@lucascaton

This comment has been minimized.

Copy link

lucascaton commented Oct 18, 2014

That looks amazing dude, nice job! Congrats!

@tomekw

This comment has been minimized.

Copy link

tomekw commented Oct 18, 2014

No idea where to raise this issue but entering the fullscreen doesn't work on Yosemite (/cc @b4winckler)

Top left corner:

http://cl.ly/image/292113231m3L

Bottom left corner:

http://cl.ly/image/120P0M1R122Q

@maxcountryman

This comment has been minimized.

Copy link

maxcountryman commented Oct 20, 2014

@tomekw I'm having the same problem.

@benoitc

This comment has been minimized.

Copy link

benoitc commented Oct 27, 2014

@tomekw @maxcountryman I applied this patch in my repo [1] from the google code tracker [2] as a workaround. It seems to fix most case even if resizing is not that good.

[1] benoitc@9f77ac3
[2] https://code.google.com/p/macvim/issues/detail?id=514&start=100

@eric-wood

This comment has been minimized.

Copy link

eric-wood commented Oct 29, 2014

This is fantastic, really looking forward to this making it upstream! 👍 👍 👍

@RobertsChou

This comment has been minimized.

Copy link

RobertsChou commented Oct 29, 2014

Thank u , good job

@krid78

This comment has been minimized.

Copy link

krid78 commented Oct 30, 2014

I compiled and testes the version (zenangst/macvim). The issue with missing top lines when only one tab is open at full screen mode is still there.

regards

@jordwalke

This comment has been minimized.

Copy link

jordwalke commented Nov 9, 2014

👍

@vestimir

This comment has been minimized.

Copy link

vestimir commented Nov 15, 2014

Looks great. 👍

offtopic: @krid78 @benoitc @tomekw About the blank lines there's a fix in progress here - #48

@mikekreeki

This comment has been minimized.

Copy link

mikekreeki commented Dec 15, 2014

👍

1 similar comment
@eirnym

This comment has been minimized.

Copy link

eirnym commented Jan 18, 2015

👍

@luishdez

This comment has been minimized.

Copy link

luishdez commented Jan 27, 2015

Awesome work!

I will add these extras to the tasks

[ ] Use hover native scrolls ( invisible ones )
[ ] Dark mode for yosemite

@UmkaDK

This comment has been minimized.

Copy link

UmkaDK commented Jan 28, 2015

👍

@zenangst

This comment has been minimized.

Copy link
Author

zenangst commented Jan 29, 2015

Hey folks, thanks for your support and enthusiasm. Kinda swamped at work right now but this is on my todo-list... and I would love to finish pully.

@vestimir

This comment has been minimized.

Copy link

vestimir commented Jan 30, 2015

@zenangst what do you mean by

Change the way the close button looks and behaves

PS: Great job so far! 🎯

@christianparpart

This comment has been minimized.

Copy link

christianparpart commented Mar 8, 2015

hey guys. is there an update on this so far? or got it suspended?

@simono

This comment has been minimized.

Copy link

simono commented Mar 13, 2015

I don't think this repository is active anymore. #44 (comment)

@ricain

This comment has been minimized.

Copy link

ricain commented Oct 6, 2015

Hi,

This repo is no longer active, however this one is: https://github.com/macvim-dev/macvim

Any chance you could update it?

@mikekreeki

This comment has been minimized.

Copy link

mikekreeki commented Oct 6, 2015

Would be very cool 👍

@jordwalke

This comment has been minimized.

Copy link

jordwalke commented Dec 28, 2015

This would be really awesome to have. Any chance you could submit the pull request to the new official repo at https://github.com/macvim-dev/macvim ? That repo is fairly active now and I'm hoping there will be some people excited to take a closer look at your PR.

splhack added a commit to macvim-dev/macvim that referenced this pull request Dec 28, 2015

@splhack

This comment has been minimized.

Copy link
Contributor

splhack commented Dec 28, 2015

I've revised this pull request in macvim-dev/macvim#193, now you can improve and send pull requests for feature/yosemite-tab-style branch of https://github.com/macvim-dev/macvim.

splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016

splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016

splhack added a commit to macvim-dev/macvim that referenced this pull request Jan 15, 2016

MacVim Snapshot 91
Binary targets OS X 10.8(Mountain Lion), 10.9(Mavericks), 10.10(Yosemite), and 10.11(El Capitan)

- Vim patch 7.4.1090
- Fix renderer defaults settings, Core Text Renderer should be the default
- Yosemite style Tab bar based on b4winckler/macvim#45

Script interfaces have compatibility with these versions

- Lua 5.2
- Perl 5.16
- Python2 2.7
- Python3 3.5
- Ruby 2.0

@zenangst zenangst closed this Mar 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.