Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleaned up port iteration, added methods to check ports from array, checking for proper port range #30

Closed
wants to merge 2 commits into from

Conversation

stroncium
Copy link

closes #23, and closes #26

@@ -8,7 +8,7 @@
"checker",
"status"
],
"version": "1.0.0",
"version": "1.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not bump version in pull request.

And, supporting array of ports needs minor update, not patch update.

@shinnn
Copy link
Collaborator

shinnn commented Feb 23, 2015

@stroncium Great contribution, but I'll merge #28 and #29. This PR reminded me to maintain this project. Thanks.

@shinnn shinnn closed this Feb 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept lists of ports Port range is not always respected
2 participants