From 856fd2ab1fe9ea36d37af1abae7466ddc1ee2bb6 Mon Sep 17 00:00:00 2001
From: Gagan Juneja <gagandeepjuneja@gmail.com>
Date: Tue, 4 Jul 2023 20:30:14 +0530
Subject: [PATCH] Adds log4j configuration for telemetry-otel plugin (#8393)

* Adds log4j configuration for telemetry-otel plugin

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Updates changelog

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

* Fixes spotless

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>

---------

Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
---
 CHANGELOG.md                                  |  1 +
 plugins/telemetry-otel/build.gradle           | 22 +++++++++++++++
 .../config/telemetry-otel/log4j2.properties   | 27 +++++++++++++++++++
 .../tracing/OTelResourceProvider.java         |  2 +-
 4 files changed, 51 insertions(+), 1 deletion(-)
 create mode 100644 plugins/telemetry-otel/config/telemetry-otel/log4j2.properties

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7b306d645c4fb..6fbf14678910b 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -77,6 +77,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - Support OpenSSL Provider with default Netty allocator ([#5460](https://github.com/opensearch-project/OpenSearch/pull/5460))
 - Replaces ZipInputStream with ZipFile to fix Zip Slip vulnerability ([#7230](https://github.com/opensearch-project/OpenSearch/pull/7230))
 - Add missing validation/parsing of SearchBackpressureMode of SearchBackpressureSettings ([#7541](https://github.com/opensearch-project/OpenSearch/pull/7541))
+- Adds log4j configuration for telemetry LogSpanExporter ([#8393](https://github.com/opensearch-project/OpenSearch/pull/8393))
 
 ### Security
 
diff --git a/plugins/telemetry-otel/build.gradle b/plugins/telemetry-otel/build.gradle
index 7a56621be5f1e..2c275388cce38 100644
--- a/plugins/telemetry-otel/build.gradle
+++ b/plugins/telemetry-otel/build.gradle
@@ -54,3 +54,25 @@ thirdPartyAudit {
     'io.opentelemetry.sdk.autoconfigure.spi.traces.ConfigurableSpanExporterProvider'
   )
 }
+
+tasks.named("bundlePlugin").configure {
+  from('config/telemetry-otel') {
+    into 'config'
+  }
+}
+
+tasks.register("writeTestJavaPolicy") {
+  doLast {
+    final File tmp = file("${buildDir}/tmp")
+    if (tmp.exists() == false && tmp.mkdirs() == false) {
+      throw new GradleException("failed to create temporary directory [${tmp}]")
+    }
+    final File javaPolicy = file("${tmp}/java.policy")
+    javaPolicy.write(
+      [
+        "grant {",
+        "  permission java.io.FilePermission \"config\", \"read\";",
+        "};"
+      ].join("\n"))
+  }
+}
diff --git a/plugins/telemetry-otel/config/telemetry-otel/log4j2.properties b/plugins/telemetry-otel/config/telemetry-otel/log4j2.properties
new file mode 100644
index 0000000000000..544f42bd5513b
--- /dev/null
+++ b/plugins/telemetry-otel/config/telemetry-otel/log4j2.properties
@@ -0,0 +1,27 @@
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+# The OpenSearch Contributors require contributions made to
+# this file be licensed under the Apache-2.0 license or a
+# compatible open source license.
+#
+
+
+appender.tracing.type = RollingFile
+appender.tracing.name = tracing
+appender.tracing.fileName = ${sys:opensearch.logs.base_path}${sys:file.separator}${sys:opensearch.logs.cluster_name}_otel_traces.log
+appender.tracing.filePermissions = rw-r-----
+appender.tracing.layout.type = PatternLayout
+appender.tracing.layout.pattern = %m%n
+appender.tracing.filePattern = ${sys:opensearch.logs.base_path}${sys:file.separator}${sys:opensearch.logs.cluster_name}_otel_traces-%i.log.gz
+appender.tracing.policies.type = Policies
+appender.tracing.policies.size.type = SizeBasedTriggeringPolicy
+appender.tracing.policies.size.size = 1GB
+appender.tracing.strategy.type = DefaultRolloverStrategy
+appender.tracing.strategy.max = 4
+
+
+logger.exporter.name = io.opentelemetry.exporter.logging.LoggingSpanExporter
+logger.exporter.level = INFO
+logger.exporter.appenderRef.tracing.ref = tracing
+logger.exporter.additivity = false
diff --git a/plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java b/plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java
index 04bade9ec942a..292165979c2f2 100644
--- a/plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java
+++ b/plugins/telemetry-otel/src/main/java/org/opensearch/telemetry/tracing/OTelResourceProvider.java
@@ -42,7 +42,7 @@ private OTelResourceProvider() {}
     public static OpenTelemetry get(Settings settings) {
         return get(
             settings,
-            new LoggingSpanExporter(),
+            LoggingSpanExporter.create(),
             ContextPropagators.create(W3CTraceContextPropagator.getInstance()),
             Sampler.alwaysOn()
         );