Using Node 4 Features

[hzoo]

Since we dropped node < 4,

an easy win would be to change our tests to use template strings instead of

["asdfads",
"asdf"
].join('\n')

This doesn't have to be done in a single PR, and would be good for new contributors

[vgvenkat]

Hello there! Would this be conversion of all strings which use string concat using "+" in the 3 js test files as well or just the ones with join to use template strings?

[hzoo]

@vgvenkat Sorry there's already a pr for that particular change #410 (should of put a notice)

[vgvenkat]

oh. ok cool 👍🏻

[kaicataldo]

We did the same thing in the ESLint repo recently (there's one PR open that adds the final thing we wanted). This list might be helpful: eslint/eslint#6407

[hzoo]

If you want you can try https://github.com/mohebifar/lebab or https://github.com/cpojer/js-codemod (for anyone that wants to add more features)

[kaicataldo]

ESLint itself also has some fixers that could be used - prefer-template was just added recently and I used it on the main ESLint repo with no issues!

[karanjthakkar]

@hzoo Since #410 is merged, is there any other change that this issue is looking to address? I'd love to help out with other changes, if any, apart from the conversion to template strings.

[kaicataldo]

Other Node 4 features would be nice to have - arrow functions for callbacks and shorthand object properties come to mind immediately.

[kaicataldo]

There actually is a PR open with some of this work done: #425

[hzoo]

Going to close as some of this is done and don't need to track