Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulpfile changes #190

Closed
wants to merge 4 commits into from
Closed

Gulpfile changes #190

wants to merge 4 commits into from

Conversation

jamiebuilds
Copy link
Contributor

  • Uses gulpfile.babel.js
  • Bumps gulp
  • Starts to use ES6

Finally I also started moving all the contents of tasks into functions. There's more refactoring work to do here, but you'll notice that there's a bunch of extra tasks that people create when writing gulp when you can actually just use normal functions. I started the work of moving things over like this:

function clean(dir, cb) {
  del([dir], cb);
}

gulp.task('clean', done => clean(destinationFolder, done));
gulp.task('clean-tmp', done => clean('tmp', done));

Again, more refactoring can be done here, but for now everything lives within separate functions than their tasks.

@jamiebuilds
Copy link
Contributor Author

Hmm, for some reason istanbul is getting all upset

@jamiebuilds
Copy link
Contributor Author

Opened an issue in Babel

@jamesplease
Copy link
Member

Sry, updated the Gulpfile this morning @thejameskyle 🙊

@jamesplease
Copy link
Member

@thejameskyle want to split this out into smaller, easier-to-merge PRs? This is good stuff.

@jamesplease
Copy link
Member

ping @thejameskyle

@jamesplease
Copy link
Member

Opened two issues for the changes here: #211 and #212

@jamiebuilds jamiebuilds closed this Sep 6, 2015
@jamesplease jamesplease deleted the gulpfile-changes branch October 9, 2015 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants