Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @ava/babel to devDependencies #881

merged 1 commit into from Nov 10, 2020

Move @ava/babel to devDependencies #881

merged 1 commit into from Nov 10, 2020


Copy link

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other: dependencies fix.

What is the current behavior? (You can also link to an open issue here)

When installing babel-loader, @ava/babel is installed with it while it's not used

What is the new behavior?

It's not installed anymore.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information:

Adding it to dependencies instead of devDependencies was probably a mistake, this fixes it.

Copy link

Whoops thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit a4d17c0 into babel:main Nov 10, 2020
2 checks passed
@jvasseur jvasseur deleted the ava-dev-dependencies branch November 10, 2020 14:13
Copy link

pieh commented Nov 10, 2020

Any chance we could get patch release with this change?

On top of installing it unnecessarily, it also cause some problems due to engines.node - excerpt from yarn installation:

error @ava/babel@1.0.1: The engine "node" is incompatible with this module. Expected version ">=10.18.0 <11 || >=12.14.0 <13 || >=13.5.0". Got "10.16.0"
error Found incompatible module.

(@ava/babel@1.0.1's engines.node is more strict that of babel-loader itself )

Copy link

Yup, I will release later today.

Copy link

Published as 8.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants