fix: respect inputSourceMap loader option
#896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure doesn't to be caused by my changes. |
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Mar 15, 2021
…maps from file Workaround for babel/babel-loader#896
alan-agius4
added a commit
to angular/angular-cli
that referenced
this pull request
Mar 15, 2021
…maps from file Workaround for babel/babel-loader#896 (cherry picked from commit 2d6e82f)
Currently, when the loader is invoked without a `map` object the `inputSourceMap` fallbacks to `undefined`. This caused the sourcemap to be loaded by Babel since this defaults to `true` https://babeljs.io/docs/en/options#inputsourcemap Thus, currently there is no way to disable `inputSourceMap` when using this loader.
alan-agius4
force-pushed
the
inputSourceMap
branch
from
8fd049e
to
526da60
Compare
|
@JLHwung, can you please merge this if CI is green? |
1 task
1 task
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
Currently, when the loader is invoked without a
mapobject theinputSourceMapfallbacks toundefined.This caused the sourcemap to be loaded by Babel since this defaults to
truehttps://babeljs.io/docs/en/options#inputsourcemapThus, currently there is no way to disable
inputSourceMapwhen using this loader.What is the new behavior?
Respect
inputSourceMapoption provided by the loader options.Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the following...
Other information: