Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug in computed properties implementation in Chrome < 52 #54
In our app, we were experiencing a crash in certain scenarios when using computed properties in Chrome < 52. This bug has been fixed in Chrome 52 and above.
Given that, would you accept a pull request to bump the required Chrome version to 52 for transform-es2015-computed-properties? I suppose Opera would have been affected as well. Would this need to be authored as an override in the build-data.js script?
referenced this issue
Dec 2, 2016
V8 has a regression test for this case (https://github.com/v8/v8/blob/master/test/mjsunit/regress/regress-5033.js). I'm not sure how much sense this makes to add a test to test262, since the issue only happened with the optimizing compiler.
If there's no way to reliably check for this without
That said, if something's crashing in Chrome < 52, it's a bug, and it needs fixing.
If bumping the required version for the transform to v52 is a simple fix for this problem - especially since few users will run into this anyways - then that seems like the right path.