This repository has been archived by the owner. It is now read-only.

Data issues #7

Closed
hzoo opened this Issue Sep 6, 2016 · 7 comments

Comments

Projects
None yet
4 participants
@hzoo
Member

hzoo commented Sep 6, 2016

Data can be wrong in https://github.com/babel/babel-preset-env/blob/master/src/plugins.js.

We're using https://kangax.github.io/compat-table/es6/ now

screen shot 2016-10-08 at 11 13 43 am

There is also the issue of bugs in babel, bugs in the implementation, incomplete implementations (it supports the basic test of a feature but not everything), etc. This will require a lot of work to figure out but shouldn't be too bad with testing/attention to detail.

Can also use https://github.com/sdkennedy/babel-preset-target

@hzoo hzoo added the help wanted label Sep 6, 2016

@fson

This comment has been minimized.

Show comment
Hide comment
@fson

fson Sep 18, 2016

Contributor

I took a first stab at generating the data from ES compatibility table in #8.

Contributor

fson commented Sep 18, 2016

I took a first stab at generating the data from ES compatibility table in #8.

@chicoxyzzy

This comment has been minimized.

Show comment
Hide comment
@chicoxyzzy

chicoxyzzy Sep 24, 2016

Member

Hey! Compatibility table collaborator here! I just want you to know I will be working on moving raw data to a distinct npm package soon.

Member

chicoxyzzy commented Sep 24, 2016

Hey! Compatibility table collaborator here! I just want you to know I will be working on moving raw data to a distinct npm package soon.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 6, 2016

Member

We should figure out granularity

  • some browsers implement under a flag: (compat-table has flag, strict, etc) - what are these?
  • maybe the browser implements most of the feature (say 12/13) which covers most use cases etc.
Member

hzoo commented Oct 6, 2016

We should figure out granularity

  • some browsers implement under a flag: (compat-table has flag, strict, etc) - what are these?
  • maybe the browser implements most of the feature (say 12/13) which covers most use cases etc.
@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 6, 2016

Member

we'll need to make some PRs to compat-table as we go when we find issues/missing stuff

Member

hzoo commented Oct 6, 2016

we'll need to make some PRs to compat-table as we go when we find issues/missing stuff

@DZuz14

This comment has been minimized.

Show comment
Hide comment
@DZuz14

DZuz14 Oct 7, 2016

Any stuff a junior dev can work on? Will gladly help out with anything I can.

DZuz14 commented Oct 7, 2016

Any stuff a junior dev can work on? Will gladly help out with anything I can.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 7, 2016

Member

One thing that we want to do (continually) is check that data/plugins.json is actually correct/accurate to both what's actually true (testing in browsers/node) as well as correct to kangax.github.io/compat-table/es6/ (although annoying)

Member

hzoo commented Oct 7, 2016

One thing that we want to do (continually) is check that data/plugins.json is actually correct/accurate to both what's actually true (testing in browsers/node) as well as correct to kangax.github.io/compat-table/es6/ (although annoying)

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 15, 2016

Member

We're using compat-table already so we can close this. The issue is just that the data might be not up or date or the logic incorrect but that's an ongoing effort

Member

hzoo commented Oct 15, 2016

We're using compat-table already so we can close this. The issue is just that the data might be not up or date or the logic incorrect but that's an ongoing effort

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.