test actual requires from useBuiltIns #95

merged 2 commits into from Jan 5, 2017


None yet

1 participant

hzoo commented Dec 14, 2016

Depends on babel/babel#4999
Fixes #72

@hzoo hzoo test actual requires from useBuiltIns
@@ -0,0 +1 @@
+import "babel-polyfill";
hzoo Dec 14, 2016 edited Member

Because this is an exec.js test, it will actually run all the requires so it would fail if it wasn't found? depends on require being defined in the fixtures since we do new Function.

Might fail on npm 2 if we don't require it explicitly though..

hzoo Jan 5, 2017 Member

yep that happened (failing on npm 2)

@hzoo hzoo only run on npm 3 for now
@hzoo hzoo added the internal label Jan 5, 2017
@hzoo hzoo merged commit 21de4a1 into master Jan 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@hzoo hzoo deleted the test-modules branch Jan 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment