Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stage presets #69

Merged
merged 1 commit into from Jul 25, 2018
Merged

Remove stage presets #69

merged 1 commit into from Jul 25, 2018

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 24, 2018

@xtuc
xtuc approved these changes Jul 25, 2018
Copy link
Member

@xtuc xtuc left a comment

cool!

...stagePresets[3],
["@babel/plugin-proposal-decorators", { "legacy": true }],
"@babel/plugin-proposal-function-sent",
"@babel/plugin-proposal-export-namespace-from",

This comment has been minimized.

@hzoo

hzoo Jul 25, 2018
Member

FYI This got moved to a needs consensus but not merged yet: tc39/ecma262#1174

@hzoo hzoo merged commit 38f5e86 into babel:master Jul 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo
Copy link
Member

@hzoo hzoo commented Jul 25, 2018

Going to be interesting to maintain, hopefully it's not that bad.

@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:stage-presets branch Jul 25, 2018
@nicolo-ribaudo
Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo commented Jul 25, 2018

I don't think that we should update those lists, since they only represents what stage presets had before being removed.

@hzoo
Copy link
Member

@hzoo hzoo commented Jul 25, 2018

Yeah that's what's I was getting at as well, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.