Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split @babel/runtime into 2 modules via @babel/runtime-corejs2 #71

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Aug 10, 2018

@hzoo
Copy link
Member

hzoo left a comment

Should we remove the original runtime? Don't need both. But it depends on if they want corejs or not. Technically if they used helpers true or false, or polyfill true/false it would be different as well but it gets complicated haha

And what happens if you use transform-runtime with options already?

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Aug 11, 2018

I updatet the PR:

  • Don't duplicate the runtime in the dependencies
  • Replace runime -> runtime-corejs only when the old version did already inclue the runtime:
    @babel/runtime: 7.0.0-beta.35 -> @babel/runtime-corejs
    @babel/runtime: 7.0.0-rc.1 -> @babel/runtime
    
  • Only add the corejs option when upgrading from Babel 6. Display a warning for Babel 7 since it could be an old beta with corejs included in babel/runtime.
) {
// 7.0.0-alpha.5 <= x <= 7.0.0-beta.55
console.warn(
"Babel was not able to infer dedice wether or not to add a "

This comment has been minimized.

@existentialism

existentialism Aug 28, 2018

Member

Nit:

Babel was not able to decide whether or not to add a

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:runtime-corejs2 branch 2 times, most recently from 47c8291 to 6762617 Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.