diff --git a/packages/babel-helper-call-delegate/src/index.js b/packages/babel-helper-call-delegate/src/index.js index 4acee88b9afa..7843584620e4 100644 --- a/packages/babel-helper-call-delegate/src/index.js +++ b/packages/babel-helper-call-delegate/src/index.js @@ -35,7 +35,6 @@ export default function( let callee = container; let args = []; - // todo: only hoist if necessary if (shouldHoistVariables) { hoistVariables(path, id => scope.push({ id })); } diff --git a/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/input.js b/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/exec.js similarity index 66% rename from packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/input.js rename to packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/exec.js index 21b6653d47b0..1f35e3dd4526 100644 --- a/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/input.js +++ b/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/exec.js @@ -2,7 +2,7 @@ var x = 1 function foo(x, y = function () { x = 2 }) { var x = 3 y() - console.log(x); + expect(x).toBe(3); } foo() -console.log(x); +expect(x).toBe(1); diff --git a/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/output.js b/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/output.js deleted file mode 100644 index 050d71564b0b..000000000000 --- a/packages/babel-plugin-transform-parameters/test/fixtures/parameters/var-same-as-param-closure/output.js +++ /dev/null @@ -1,15 +0,0 @@ -var x = 1; - -function foo(x) { - var y = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : function () { - x = 2; - }; - return function () { - var x = 3; - y(); - console.log(x); - }(); -} - -foo(); -console.log(x);