From 7d5e8c204d74ab9009490f02af9d87e490d85345 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hu=C3=A1ng=20J=C3=B9nli=C3=A0ng?= Date: Sat, 28 Dec 2019 23:02:49 -0500 Subject: [PATCH] refactor: remove unecessary trailing comma record --- packages/babel-parser/src/parser/expression.js | 2 +- .../basic/function-trailing-comma-shorthand/output.json | 3 --- .../comments/basic/function-trailing-comma/output.json | 3 --- .../fixtures/es2017/trailing-function-commas/1/output.json | 3 --- .../dynamic-import/invalid-trailing-comma/output.json | 3 --- 5 files changed, 1 insertion(+), 13 deletions(-) diff --git a/packages/babel-parser/src/parser/expression.js b/packages/babel-parser/src/parser/expression.js index a84e96752a61..c6679c27526d 100644 --- a/packages/babel-parser/src/parser/expression.js +++ b/packages/babel-parser/src/parser/expression.js @@ -644,7 +644,7 @@ export default class ExpressionParser extends LValParser { state.maybeAsyncArrow, base.type === "Import", base.type !== "Super", - node, + state.maybeAsyncArrow ? node : undefined, ); } this.finishCallExpression(node, state.optionalChainMember); diff --git a/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma-shorthand/output.json b/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma-shorthand/output.json index b27cadb955a0..3e22bc1678e5 100644 --- a/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma-shorthand/output.json +++ b/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma-shorthand/output.json @@ -74,9 +74,6 @@ }, "name": "fn" }, - "extra": { - "trailingComma": 11 - }, "arguments": [ { "type": "Identifier", diff --git a/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma/output.json b/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma/output.json index a224e1810b5d..6147660b79f9 100644 --- a/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma/output.json +++ b/packages/babel-parser/test/fixtures/comments/basic/function-trailing-comma/output.json @@ -74,9 +74,6 @@ }, "name": "fn" }, - "extra": { - "trailingComma": 7 - }, "arguments": [ { "type": "Identifier", diff --git a/packages/babel-parser/test/fixtures/es2017/trailing-function-commas/1/output.json b/packages/babel-parser/test/fixtures/es2017/trailing-function-commas/1/output.json index 40aa85102591..2373fc85c177 100644 --- a/packages/babel-parser/test/fixtures/es2017/trailing-function-commas/1/output.json +++ b/packages/babel-parser/test/fixtures/es2017/trailing-function-commas/1/output.json @@ -74,9 +74,6 @@ }, "name": "log" }, - "extra": { - "trailingComma": 13 - }, "arguments": [ { "type": "Identifier", diff --git a/packages/babel-parser/test/fixtures/experimental/dynamic-import/invalid-trailing-comma/output.json b/packages/babel-parser/test/fixtures/experimental/dynamic-import/invalid-trailing-comma/output.json index fde34fb849ab..815e4d649930 100644 --- a/packages/babel-parser/test/fixtures/experimental/dynamic-import/invalid-trailing-comma/output.json +++ b/packages/babel-parser/test/fixtures/experimental/dynamic-import/invalid-trailing-comma/output.json @@ -75,9 +75,6 @@ } } }, - "extra": { - "trailingComma": 12 - }, "arguments": [ { "type": "StringLiteral",