fix: register inserted class declaration (#10302)

* Decorators legacy: register inserted declaration For compatibility with the Typescript plugin Fixes #10264 * Register declaration but also keep replaceWithMultiple
babel · Aug 8, 2019 · ba2c0f7 · ba2c0f7
1 parent 5fb4d84
commit ba2c0f7
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/packages/babel-plugin-proposal-decorators/src/transformer-legacy.js b/packages/babel-plugin-proposal-decorators/src/transformer-legacy.js
@@ -237,7 +237,7 @@ export default {
 
     const replacement = decoratedClassToExpression(decl);
     if (replacement) {
-      path.replaceWithMultiple([
+      const [varDeclPath] = path.replaceWithMultiple([
         replacement,
         t.exportNamedDeclaration(null, [
           t.exportSpecifier(
@@ -246,6 +246,10 @@ export default {
           ),
         ]),
       ]);
+
+      if (!decl.node.id) {
+        path.scope.registerDeclaration(varDeclPath);
+      }
     }
   },
   ClassDeclaration(path) {

diff --git a/packages/babel-plugin-proposal-decorators/test/fixtures/legacy-regression/10264/input.mjs b/packages/babel-plugin-proposal-decorators/test/fixtures/legacy-regression/10264/input.mjs
@@ -0,0 +1,4 @@
+function myDecorator(decoratee) {}
+
+@myDecorator
+export default class {}
diff --git a/packages/babel-plugin-proposal-decorators/test/fixtures/legacy-regression/10264/options.json b/packages/babel-plugin-proposal-decorators/test/fixtures/legacy-regression/10264/options.json
@@ -0,0 +1,6 @@
+{
+  "plugins": [
+    "transform-typescript",
+    [ "proposal-decorators", { "legacy": true } ]
+  ]
+}
diff --git a/packages/babel-plugin-proposal-decorators/test/fixtures/legacy-regression/10264/output.mjs b/packages/babel-plugin-proposal-decorators/test/fixtures/legacy-regression/10264/output.mjs
@@ -0,0 +1,7 @@
+var _class2;
+
+function myDecorator(decoratee) {}
+
+let _class = myDecorator(_class2 = class {}) || _class2;
+
+export { _class as default };