Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake this type for function this argument is not handled #10138

Open
jounii opened this issue Jun 28, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@jounii
Copy link

commented Jun 28, 2019

Bug Report

Current Behavior

If providing Typescript function fake this type (https://github.com/Microsoft/TypeScript/wiki/What's-new-in-TypeScript#specifying-the-type-of-this-for-functions) it is treated as real argument even though it should be omitted. Current functionality makes it impossible to type this.

function fakethis(this: any, ...args: any[]) {
  console.log(args)
}

Expected behavior/code

As per Typescript typings, the "this: any" argument should be treated as it was not there and "...args" should contain all given arguments and not just starting from the second argument.

Environment

  • Babel version(s): 7.0.0-bridge.0
  • Node/npm version: v12.4.0
  • OS: macOS 10.14.5
  • How you are using Babel: React Native metro
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2019

Hey @jounii! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.