Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code frame formatting messed up when using colors #10159

Closed
devsnek opened this issue Jul 4, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@devsnek
Copy link

commented Jul 4, 2019

Bug Report

Current Behavior
Using color in code frames causes odd formatting

Input Code

console.log(codeFrameColumns(`
function a(b, c) {
  return b + c;
}
`, {
  start: {
    line: 2,
    column: 1,
  },
  end: {
    line: 4,
    column: 1,
  },
}, {
  highlightCode: true,
  message: 'Message about things',
}));

Expected behavior/code
Arrow formatting remains consistent

Environment

  • @babel/code-frame: 7.0.0

Possible Solution

Additional context/Screenshots

Input code from above with and without highlightCode:

--

P.S. it also seems that with the non-color output, the first line is 1 character short.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

Hey @devsnek! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Jul 4, 2019

We peobably are counting "hidden" ANSI codes, while we shouldn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.