Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing @babel/node@7.5.5 also install @babel/polyfill as dependency #10295

Open
ApolloTang opened this issue Aug 3, 2019 · 2 comments

Comments

@ApolloTang
Copy link

commented Aug 3, 2019

Bug Report

Current Behavior

$ yarn init -y
yarn init v1.16.0
warning The yes flag has been set. This will automatically answer yes to all questions, which may have security implications.
success Saved package.json
✨  Done in 0.02s.
~/Desktop/test-babel-node
$ yarn add @babel/node
yarn add v1.16.0
info No lockfile found.
[1/4] 🔍  Resolving packages...
warning @babel/node > @babel/polyfill@7.4.4: 🚨 As of Babel 7.4.0, this
package has been deprecated in favor of directly
including core-js/stable (to polyfill ECMAScript
features) and regenerator-runtime/runtime
(needed to use transpiled generator functions):

  > import "core-js/stable";
  > import "regenerator-runtime/runtime";
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "@babel/node > @babel/register@7.5.5" has unmet peer dependency "@babel/core@^7.0.0-0".
warning " > @babel/node@7.5.5" has unmet peer dependency "@babel/core@^7.0.0-0".
[4/4] 🔨  Building fresh packages...
success Saved lockfile.
success Saved 38 new dependencies.
info Direct dependencies
└─ @babel/node@7.5.5
info All dependencies
├─ @babel/node@7.5.5
├─ @babel/polyfill@7.4.4
├─ @babel/register@7.5.5

+++ output not shown +++

├─ core-js@2.6.9

+++ output not shown +++

├─ regenerator-runtime@0.13.3
├─ semver@5.7.0
├─ source-map-support@0.5.13
├─ source-map@0.6.1
└─ v8flags@3.1.3
✨  Done in 3.23s.

Expected behavior/code

Since we have migrated to core-js@3, we should not have the following dependencies installed by default:

  • @babel/polyfill
  • core-js@2
  • regenerator-runtime

Environment

  • Babel version(s): [@babel/node@7.5.5]
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Aug 3, 2019

Hey @ApolloTang! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Aug 3, 2019

It should be updated like the warnng says. Would you like to open a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.