Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] Not compiling because of JSDoc TS8020 #10408

Closed
AnandChowdhary opened this issue Sep 7, 2019 · 6 comments

Comments

@AnandChowdhary
Copy link

commented Sep 7, 2019

Bug Report

Current Behavior
The most recent recent publish of @babel/types is not compiling with TypeScript. The error is TS8020, JSDoc types can only be used inside documentation comments.

Input Code

node_modules/@babel/types/lib/index.d.ts:2098:30 - error TS8020: JSDoc types can only be used inside documentation comments.
2098 export function isNode(node: ?object): boolean
                                  ~~~~~~~
node_modules/@babel/types/lib/index.d.ts:2100:52 - error TS8020: JSDoc types can only be used inside documentation comments.
2100 export function isPlaceholderType(placeholderType: ?string, targetType: string): boolean
                                                        ~~~~~~~
node_modules/@babel/types/lib/index.d.ts:2104:34 - error TS8020: JSDoc types can only be used inside documentation comments.
2104 export function isType(nodetype: ?string, targetType: string): boolean
                                      ~~~~~~~
Found 3 errors.

@AnandChowdhary AnandChowdhary changed the title [types] [types] Not compiling because of JSDoc TS8020 Sep 7, 2019

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 7, 2019

Hey @AnandChowdhary! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

This has been fixed in @babel/types 7.6.1

@AnandChowdhary

This comment has been minimized.

Copy link
Author

commented Sep 8, 2019

Awesome! Can we also patch update and publish all dependents of @babel/types, like @babel/core and @babel/preset-env? 😄

@AnandChowdhary

This comment has been minimized.

Copy link
Author

commented Sep 8, 2019

Though #10403 is fixed already, perhaps we can keep this issue open until all packages using @babel/types are updated as well?

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Sep 8, 2019

It isn't needed, since they don't pin their dependencies. yarn upgrade @babel/types (or the equivalent npm command) should be enough.

nathan818fr added a commit to nathan818fr/hipay-professional-sdk-js that referenced this issue Sep 10, 2019
@JLHwung

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

Close as it duplicates #10403

@JLHwung JLHwung closed this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.