Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

objectSpread not working with boolean arguments #10482

Open
MengMengYan opened this issue Sep 23, 2019 · 2 comments

Comments

@MengMengYan
Copy link

commented Sep 23, 2019

Hi,
We have a scenario where objectSpread throws an exception when the arguments list contains a boolean.

This particular piece of code

function _objectSpread(target) {
  for (var i = 1; i < arguments.length; i++) {
    var source = arguments[i] != null  ? arguments[i] : {};
    var ownKeys = Object.keys(source);

    if (typeof Object.getOwnPropertySymbols === 'function') {
      ownKeys = ownKeys.concat(Object.getOwnPropertySymbols(source).filter(function (sym) {
        return Object.getOwnPropertyDescriptor(source, sym).enumerable;
      }));
    }

    ownKeys.forEach(function (key) {
      defineProperty(target, key, source[key]);
    });
  }

  return target;
}

gives an exception : Object.keys argument is not an object.

Shouldn't the check be like:
var source = arguments[i] != null && typeof arguments[i] === 'object' ? arguments[i] : {};

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 23, 2019

Hey @MengMengYan! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

commented Sep 23, 2019

Object.keys should support boolean arguments. You might need to load a polyfill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.