Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filename is duplicated for errors created by `path.buildCodeFrameError` in 7.6.3 #10531

Closed
coreyfarrell opened this issue Oct 9, 2019 · 1 comment · Fixed by #10539

Comments

@coreyfarrell
Copy link
Contributor

commented Oct 9, 2019

Bug Report

Input Code

const path = require('path');
const {transformSync} = require('@babel/core');

transformSync('', {
	filename: path.resolve('filename.js'),
	plugins: [
		() => ({
			visitor: {
				Program(path) {
					throw path.buildCodeFrameError('example error');
				}
			}
		})
	]
});

Expected behavior/code
The first line of error.message should be /path/to/filename.js: example error

Current Behavior
The first line of error.message is /path/to/filename.js: /path/to/filename.js: example error

Babel Configuration (.babelrc, package.json, cli command)

None / see code.

Environment

  • Babel version(s): 7.6.3
  • Node/npm version: node 8+
  • OS: all
  • Monorepo: no
  • How you are using Babel: API

Possible Solution
Since packages/babel-core/src/transformation/index.js now prepends the error with the message maybe path.buildCodeFrameError should not do the same.

Additional context/Screenshots
Introduced by #10511. CC @JLHwung

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2019

Hey @coreyfarrell! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.