Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotation is stripped from Typescript template #10636

Open
dentrado opened this issue Nov 4, 2019 · 2 comments

Comments

@dentrado
Copy link
Contributor

@dentrado dentrado commented Nov 4, 2019

Bug Report

Current Behavior
A @babel/template template with placeholders and a type annotation generates code without the annotation. A template without placeholders works as expected.

Input Code

const template = require('@babel/template').default
const generate = require('@babel/generator').default
const t = require('@babel/types')
​
const withType = template({plugins:['typescript']}).ast`
    const greeting: string = 'Hello';
`
console.log(generate(withType).code)
// => "const greeting: string = 'Hello';"const typeDisappears = template({plugins:['typescript']}).ast`
    const ${t.identifier('greeting')}: string = 'Hello';
`
console.log(generate(typeDisappears).code)
// => "const greeting = 'Hello';"

Expected behavior/code

I expect both templates above to keep the : string type in the generated code.

Babel Configuration (.babelrc, package.json, cli command)

No configuration, used from code, see above.

Environment

  • Babel version(s): 7.6.4
  • Node/npm version: Node 12.9.1 / yarn 1.17.3
  • Monorepo: no
@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Nov 4, 2019

Hey @dentrado! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 4, 2019

The root cause of this bug is that the type annotation is a child node of the identifier. The identifier you are passing to @babel/template doesn't have the type annotation, and thus the one in the template is discarded.

#9545 would be a possible way of fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.