Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript 3.7 syntax: `asserts this` #10671

Closed
thorn0 opened this issue Nov 6, 2019 · 1 comment · Fixed by #10677
Assignees

Comments

@thorn0
Copy link
Contributor

@thorn0 thorn0 commented Nov 6, 2019

Bug Report

Current Behavior
In #10527, it wasn't taken into account that the asserts keyword can be followed by this, not only by an identifier. Now it's a parser error, Unexpected token. Babel REPL.

Input Code

class Test {
    assertIsTest2(): asserts this is Test2 {
        if (this instanceof Test2) return;
        throw new Error();
    }
}

Expected behavior/code
Should parse. TypeScript playground.

Environment

  • Babel version(s): 7.7.0
  • How you are using Babel: @babel/parser
@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Nov 6, 2019

Hey @thorn0! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.