Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint-related packages migration - TODO #10709

Open
nicolo-ribaudo opened this issue Nov 14, 2019 · 10 comments
Open

ESLint-related packages migration - TODO #10709

nicolo-ribaudo opened this issue Nov 14, 2019 · 10 comments
Assignees

Comments

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 14, 2019

  • Merge #10705
  • Remove lock files from new packages (#10711)
  • Ignore new packages while linting
  • Make "Lint" pass on CI (#10712)
  • Move CHANGELOG files to .github/ (#10714)
  • Actually rename the new packages (#10715)
  • Prevent lerna from publishing those packages until we are ready (@nicolo-ribaudo) (#10722)
  • Unify build process (#10723, #10729)
  • Migrate from mocha to jest (which is used by the other @babel/ packages) (#10716)
  • Disable tests for ESLint related packages on unsupported node versions (#10730)
@rajasekarm

This comment has been minimized.

Copy link
Member

@rajasekarm rajasekarm commented Nov 14, 2019

Can I pick this? Migrate from mocha to jest

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo commented Nov 14, 2019

Ok 👍

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo commented Nov 14, 2019

If you wait 5 mins, I will push the linting PR first

@JLHwung

This comment has been minimized.

Copy link
Contributor

@JLHwung JLHwung commented Nov 14, 2019

Yep, let's make the CI green again.

@kaicataldo

This comment has been minimized.

Copy link
Member

@kaicataldo kaicataldo commented Nov 15, 2019

Assigning this to myself so I don't lose track of this, but that doesn't mean others should hold off on working on these tasks.

@kaicataldo

This comment has been minimized.

Copy link
Member

@kaicataldo kaicataldo commented Nov 18, 2019

Looks like we’re all set except for renaming the packages. Thoughts on how to proceed? I’m of the mind that we should release all of the new namespaced ESLint packages with the next minor release that occurs after the new packages are ready.

@nicolo-ribaudo nicolo-ribaudo mentioned this issue Nov 20, 2019
0 of 7 tasks complete
@thiagoarrais

This comment has been minimized.

Copy link
Contributor

@thiagoarrais thiagoarrais commented Nov 25, 2019

Maybe related? babel/babel-eslint#807

@rajasekarm: what do you think?

@rajasekarm

This comment has been minimized.

Copy link
Member

@rajasekarm rajasekarm commented Nov 29, 2019

Yeah, This changes should be added here.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo commented Nov 29, 2019

Please wait for Kai's go-ahead before opening new features/bug fixes in this repo.

@rajasekarm

This comment has been minimized.

Copy link
Member

@rajasekarm rajasekarm commented Nov 29, 2019

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.