Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric separator to shippedProposals in preset-env #10921

Open
JLHwung opened this issue Dec 24, 2019 · 7 comments · May be fixed by #10971
Open

Add numeric separator to shippedProposals in preset-env #10921

JLHwung opened this issue Dec 24, 2019 · 7 comments · May be fixed by #10971

Comments

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 24, 2019

Feature Request

Numeric Separator is Stage 3 and shipped in Chrome 75/Firefox 70/Safari 13!


![](https://example.com/you-know-how-excited-i-am.gif)

This means that it should be enabled via shippedProposals: true options in @babel/preset-env 🎉

It should be done similarly to this commit: 28bbd9f

  1. Add it to packages/babel-preset-env/src/available-plugins.js
  2. Add the compat-table mapping to packages/babel-preset-env/data/plugin-features.js (you can find the correct feature name at https://kangax.github.io/compat-table/esnext/)
  3. Add it to packages/babel-preset-env/data/shipped-proposals.js
  4. Run cd packages/preset-env and yarn build-data to update the data about the supported browser versions
  5. Add it to @babel/preset-env-standalone (packages/babel-preset-env-standalone/src/available-plugins.js)
  6. Update the test as needed (you don't need to write new tests)
  7. PR! 🎉

If it is the first time that you contribute to Babel, follow these steps: (you need to have make and yarn available on your machine)

  1. Write a comment there to let other possible contributors know that you are working on this bug.
  2. Fork the repo
  3. Run git clone https://github.com/<YOUR_USERNAME>/babel.git && cd babel
  4. Run yarn && make bootstrap
  5. Wait
  6. Run make watch (or make build whenever you change a file)
  7. Add a test if needed (only input.js; output.js will be automatically generated)
  8. Update the code!
  9. yarn jest babel-preset-env to run the tests
    • Since you don't need to write new tests, you can run OVERWRITE=true yarn jest babel-preset-env and they will be automatically updated.
  10. If it is working, run make test to run all the tests
  11. Run git push and open a PR!
@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Dec 24, 2019

Hey @JLHwung! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@Wetinee

This comment has been minimized.

Copy link

@Wetinee Wetinee commented Dec 24, 2019

I'd like to try this out, with such detailed instructions above. ;)

@rajasekarm

This comment has been minimized.

Copy link
Member

@rajasekarm rajasekarm commented Dec 30, 2019

@Wetinee Any updates on this issue? Let us know if you need any help.

@Wetinee

This comment has been minimized.

Copy link

@Wetinee Wetinee commented Dec 31, 2019

@Wetinee Any updates on this issue? Let us know if you need any help.

Sure! It should be done by tomorrow. ;)

@AjayPoshak

This comment has been minimized.

Copy link

@AjayPoshak AjayPoshak commented Jan 8, 2020

I would like to give it a try.

@existentialism

This comment has been minimized.

Copy link
Member

@existentialism existentialism commented Jan 8, 2020

@AjayPoshak let's give @Wetinee a chance to respond!

@JLHwung

This comment has been minimized.

Copy link
Contributor Author

@JLHwung JLHwung commented Jan 9, 2020

@Wetinee has talked to me offline a bit. She's working on it after the holiday seasons.

@Wetinee Wetinee linked a pull request that will close this issue Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.