Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel-generator]: jsescOption.numbers does not affect NumericLiterals #10960

Open
sanex3339 opened this issue Jan 4, 2020 · 4 comments · May be fixed by #11028
Open

[babel-generator]: jsescOption.numbers does not affect NumericLiterals #10960

sanex3339 opened this issue Jan 4, 2020 · 4 comments · May be fixed by #11028

Comments

@sanex3339
Copy link

@sanex3339 sanex3339 commented Jan 4, 2020

Bug Report

  • I would like to work on a fix!

Current Behavior
Currently, when I set:

{
    jsescOption: {
        numbers: 'hexadecimal'
    }
}

This option has not affects any numbers that @babel/generator is generated.

For example i need the following in the output generated code:

var foo = 0x1;

Expected behavior/code

{
    jsescOption: {
        numbers: 'hexadecimal'
    }
}

This option should affect any numbers that @babel/generator is generated

  • @babel/generator version: 7.7.7
  • Node/npm version: Node 12

Possible Solution
Looks like here: https://github.com/babel/babel/blob/master/packages/babel-generator/src/generators/types.js#L121
number value should be generated using jsesc like in StringLiteral

@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Jan 4, 2020

Hey @sanex3339! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

@sidntrivedi012

This comment has been minimized.

Copy link
Contributor

@sidntrivedi012 sidntrivedi012 commented Jan 17, 2020

@nicolo-ribaudo I would like to work on this. Can you please guide how to proceed? Thanks :)

@sanex3339

This comment has been minimized.

Copy link
Author

@sanex3339 sanex3339 commented Jan 17, 2020

Set the options as descrived above.

With these options, all numbers should be generated in hexadecimal view:
0 -> 0x0

@sidntrivedi012

This comment has been minimized.

Copy link
Contributor

@sidntrivedi012 sidntrivedi012 commented Jan 17, 2020

Made a Draft PR at #11028 . PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.