Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

istanbul ignore abstract of class method #11012

Open
bennypowers opened this issue Jan 15, 2020 · 1 comment
Open

istanbul ignore abstract of class method #11012

bennypowers opened this issue Jan 15, 2020 · 1 comment

Comments

@bennypowers
Copy link

@bennypowers bennypowers commented Jan 15, 2020

Bug Report

  • I would like to work on a fix!

Current Behavior
A clear and concise description of the behavior.

Input Code

class PoorlyInstrumented {
  @thing field;
  
  /**
   * @abstract
   * @private
   * istanbul ignore next
   */
  a() {}

  /**
   * @abstract
   * @private
   */
  /* istanbul ignore next */b() {}

  /**
   * @abstract
   * @private
   * istanbul ignore next
   */
  c() { }
  
  /**
   * @abstract
   * @private
   */
  /* istanbul ignore next */d() { }

  /**
   * @abstract
   * @private
   */
  e/* istanbul ignore next */() { }
  /* istanbul ignore next */   
  /**
   * @abstract
   * @private
   */
  f() { }
}

Expected behavior/code
I expected comments to be attached to functions such that istanbul can pick up on them in all above cases

Babel Configuration (babel.config.js, .babelrc, package.json#babel, cli command, .eslintrc)
See REPL

Environment
See REPL

- Babel version(s): v7.8.3
- Node/npm version: n/a
- OS: n/a
- Monorepo: n/a
- How you are using Babel: REPL

Additional context/Screenshots
See also: gotwarlost/istanbul#445

@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Jan 15, 2020

Hey @bennypowers! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.