Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel skip searching for browserslist config in some unexpected condition #11123

Open
fengzilong opened this issue Feb 11, 2020 · 1 comment · May be fixed by #11124
Open

babel skip searching for browserslist config in some unexpected condition #11123

fengzilong opened this issue Feb 11, 2020 · 1 comment · May be fixed by #11124

Comments

@fengzilong
Copy link

@fengzilong fengzilong commented Feb 11, 2020

Bug Report

  • I would like to work on a fix!

Current Behavior

If we use targets like this for preset-env

{
  targets: {
    esmodules: false
  }
}

babel won't search for browserslist config file

Input Code

Expected behavior/code

Should still search for browserslist config file even if targets is set to esmodules: false

Babel Configuration (babel.config.js, .babelrc, package.json#babel, cli command, .eslintrc)

  • Filename: babel.config.js
{
  presets: [
    [
      '@babel/preset-env',
      {
        targets: {
          esmodules: false
        }
      }
    ]
  ]
}

Environment

- Babel version(s): v7.7.5
- Node/npm version: Node v10.18.0 / npm v6.13.4
- OS: OSX 10.12.3
- Monorepo: lerna
- How you are using Babel: loader

Possible Solution

Additional context/Screenshots

@babel-bot

This comment has been minimized.

Copy link
Collaborator

@babel-bot babel-bot commented Feb 11, 2020

Hey @fengzilong! We really appreciate you taking the time to report an issue. The collaborators on this project attempt to help as many people as possible, but we're a limited number of volunteers, so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack community that typically always has someone willing to help. You can sign-up here for an invite."

fengzilong added a commit to fengzilong/babel that referenced this issue Feb 11, 2020
closes babel#11123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.