New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run coverage on 1 build (maybe the latest node) #5169

Closed
hzoo opened this Issue Jan 20, 2017 · 0 comments

Comments

Projects
None yet
2 participants
@hzoo
Member

hzoo commented Jan 20, 2017

There shouldn't need to be a reason for us to run the code coverage for each node version in travis?

Similar to how we do flow/lint checks on a separate build, except in this case we still have to do make boostrap and run tests so it makes sense to run it on the latest node.

you will want to check

  - 'if [ -z "${LINT-}" ]; then make test-ci ; fi'

Right now we run make test-ci so we probably want another command to specifically test coverage as well tests and another one that only does testing.

@hzoo hzoo added the help wanted label Jan 20, 2017

@hzoo hzoo referenced this issue Jan 20, 2017

Merged

build once on ci #5177

@babel-bot babel-bot added the Has PR label Jan 21, 2017

@hzoo hzoo closed this in #5182 Jan 21, 2017

@lock lock bot added the outdated label May 5, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.