New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Replace lodash/assign with Object.assign #5353

Closed
danez opened this Issue Feb 20, 2017 · 4 comments

Comments

Projects
None yet
4 participants
@danez
Member

danez commented Feb 20, 2017

We currently us lodash/assign in the codebase: https://lodash.com/docs/4.17.4#assign

For example here

import assign from "lodash/assign";

This is unnecessary for babel 7 as node >4 has the same functionality built-in with Object.assign. : https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Object/assign


  • Comment below you are going to do this (for others to know)
  • Read CONTRIBUTING.md
  • Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
  • Join our slack if you haven't already if you need more immediate help or just comment in this issue/PR
  • Search for imports of lodash/assign and its usages and change to use Object.assign
  • Search for imports of lodash and usages (lodsh.assign) and change to use Object.assign
  • In the packages where some lodash imports were removed due to the last two tasks, check if these usages were the last ones to use lodash and if so remove lodashdependency from package.json
  • Base PR on branch 7.0
@mdapper

This comment has been minimized.

Contributor

mdapper commented Feb 21, 2017

I'd like to work on this one @danez if you don't mind!

mdapper added a commit to mdapper/babel that referenced this issue Feb 21, 2017

Replace lodash/assign with Object.assign
Remove imports to lodash/assign and replace assign with Object.assign.
The lodash/assign is unnecessary for babel 7 as node >4 has the same
functionality built-in with Object.assign as used here.

This resolve the [issue 5353](babel#5353)
@danez

This comment has been minimized.

Member

danez commented Feb 21, 2017

Sure, if you have any questions it is the best to join our slack and ask there in #development

@mdapper

This comment has been minimized.

Contributor

mdapper commented Feb 21, 2017

Great, I am already there. I made the changes but I want to test them first. If I have any questions I will ask there.

@hzoo hzoo added this to the Babel 7 milestone Feb 22, 2017

@mdapper mdapper referenced this issue Feb 22, 2017

Merged

Replace lodash/assign with Object.assign #5356

3 of 3 tasks complete

@babel-bot babel-bot added the Has PR label Feb 22, 2017

mdapper added a commit to mdapper/babel that referenced this issue Feb 22, 2017

Replace lodash/assign with Object.assign
Remove imports to lodash/assign and replace assign with Object.assign.
The lodash/assign is unnecessary for babel 7 as node >4 has the same
functionality built-in with Object.assign as used here.

This resolve the [issue 5353](babel#5353)

hzoo added a commit that referenced this issue Feb 22, 2017

Replace lodash/assign with Object.assign (#5356)
Remove imports to lodash/assign and replace assign with Object.assign.
The lodash/assign is unnecessary for babel 7 as node >4 has the same
functionality built-in with Object.assign as used here.

This resolve the [issue 5353](#5353)
@hzoo

This comment has been minimized.

Member

hzoo commented Feb 22, 2017

Closed in #5356

@hzoo hzoo closed this Feb 22, 2017

@lock lock bot added the outdated label May 5, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.