Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-generator: await (a||b) loses parentheses #5428

Closed
hzoo opened this issue Mar 7, 2017 · 1 comment
Closed

babel-generator: await (a||b) loses parentheses #5428

hzoo opened this issue Mar 7, 2017 · 1 comment

Comments

@hzoo
Copy link
Member

@hzoo hzoo commented Mar 7, 2017

Original issue submitted by @marcello3d in babel/minify#460

const a = async () => await (a||b)

becomes

const a=async()=>await a||b;

should be

const a=async()=>await(a||b);
@aaronang

This comment has been minimized.

Copy link
Member

@aaronang aaronang commented Mar 8, 2017

I will work on this one 😄

@hzoo hzoo added the i: bug label Mar 8, 2017
@aaronang aaronang added the claimed label Mar 8, 2017
aaronang added a commit that referenced this issue Mar 8, 2017
@babel-bot babel-bot added the Has PR label Mar 8, 2017
@hzoo hzoo closed this in #5433 Mar 9, 2017
hzoo added a commit that referenced this issue Mar 9, 2017
hzoo added a commit that referenced this issue Mar 13, 2017
hzoo added a commit that referenced this issue Mar 13, 2017
hulkish added a commit to hulkish/babel that referenced this issue May 2, 2017
* 'master' of github.com:hulkish/babel: (37 commits)
  Increase the code coverage for traverse evaluation (babel#5363)
  Improve options documentation for `babel-plugin-transform-runtime` babel#5401
  [doc] Fix: comments in usage w/ options babel#5400
  document cache option for babel-register babel#5440
  Update coffescript/register reference link address babel#5475
  Update babel-generator's README babel#5517
  Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573
  Remove incorrect docs. babel#5580
  Update transform-es2015-modules-commonjs doc babel#5588
  Fix replacing function declaration in export default (fixes babel#4468) (babel#5456)
  Fix a typo: occurences -> occurrences (babel#5575)
  Fix changelog [skip ci]
  Treat "await" as an invalid identifier (babel#4954)
  Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486)
  docs: [skip ci] update documentation
  v6.24.0
  changelog for 6.24.0 [skip ci] (babel#5452)
  Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453)
  Use absolute paths in Babel's CONTRIBUTING.md (babel#5431)
  Fixed broken links in README.md [skip ci] (babel#5449)
  ...
existentialism added a commit that referenced this issue May 19, 2017
@lock lock bot added the outdated label May 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.