New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Remove aliased helpers from babel-runtime #5472

Closed
loganfsmyth opened this Issue Mar 15, 2017 · 2 comments

Comments

Projects
None yet
5 participants
@loganfsmyth
Member

loganfsmyth commented Mar 15, 2017

babel-runtime's built files currently contain several aliases that are unused as far as I can tell. I haven't done any checks on the history, so I'd be curious to see why they existed in the first place. We basically output:

helpers/
  someHelper.js
  some-helper.js
  _some-helper.js

where the last two just module.exports = require('./someHelper').


  • Comment below you are going to do this (for others to know): "I'd like to work on this"
  • Read CONTRIBUTING.md (make sure you have yarn, and are on at least node 4)
  • Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
  • remember to run make build after a source code change or better just run make watch in another terminal window to auto run babel while you are developing
@JulianJason

This comment has been minimized.

Contributor

JulianJason commented Mar 16, 2017

I'd like to work on this

@hzoo

This comment has been minimized.

Member

hzoo commented Mar 23, 2017

Closed in #5516

@hzoo hzoo closed this Mar 23, 2017

@lock lock bot added the outdated label May 5, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.