New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the export-extensions plugin into two #6075

Closed
hzoo opened this Issue Aug 8, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@hzoo
Member

hzoo commented Aug 8, 2017

Reference: babel/proposals#19

The proposal has been split for a long time now but we haven't changed it. Now's an opportunity!
There is babel/proposals#16 and babel/proposals#17.

  • export-ns-from is moving to Stage 2 (and potentially later skipping the process but irrelevant atm)
  • export-default-from is staying at Stage 1 and also having some other changes
  • moving the stages is similar to #5877
  • splitting the package in 2 however means you need to make a new folder for each, etc.

  • Comment below you are going to do this (for others to know)
  • Read CONTRIBUTING.md
    • at minimum you'll need to run make bootstrap after cloning.
  • Check you are on 7.0 branch with git checkout 7.0 and then make a branch off of that to PR
  • Join our slack if you haven't already if you need more immediate help or just comment in this issue/PR
  • make the changes above
@kedromelon

This comment has been minimized.

Show comment
Hide comment
@kedromelon

kedromelon Aug 9, 2017

Contributor

interested in helping out here!

Contributor

kedromelon commented Aug 9, 2017

interested in helping out here!

@echo304

This comment has been minimized.

Show comment
Hide comment
@echo304

echo304 Aug 9, 2017

Contributor

@kedromelon If you haven't started it, can I tackle this issue? 😄

Contributor

echo304 commented Aug 9, 2017

@kedromelon If you haven't started it, can I tackle this issue? 😄

@kedromelon

This comment has been minimized.

Show comment
Hide comment
@kedromelon

kedromelon Aug 9, 2017

Contributor

@echo304 go for it!

Contributor

kedromelon commented Aug 9, 2017

@echo304 go for it!

@existentialism existentialism added claimed and removed help wanted labels Aug 9, 2017

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism

existentialism Aug 9, 2017

Member

@echo304 feel free to join our slack if you have any questions!

Member

existentialism commented Aug 9, 2017

@echo304 feel free to join our slack if you have any questions!

@echo304

This comment has been minimized.

Show comment
Hide comment
@echo304

echo304 Aug 9, 2017

Contributor

@existentialism I don't know why but I couldn't join slack. I have a question BTW 😄
After I create new directory inside packages directory for new plugin(here...for export-default and export-namespace), do I need to do something with the package setting...?
I've done make build but it seems that my test code couldn't find new package babel-plugin-transform-export-default and babel-plugin-transform-export-namespace ... 😢

Contributor

echo304 commented Aug 9, 2017

@existentialism I don't know why but I couldn't join slack. I have a question BTW 😄
After I create new directory inside packages directory for new plugin(here...for export-default and export-namespace), do I need to do something with the package setting...?
I've done make build but it seems that my test code couldn't find new package babel-plugin-transform-export-default and babel-plugin-transform-export-namespace ... 😢

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Aug 9, 2017

Member

@echo304 ahh http://slack.babeljs.io/ is down 😛 I can invite you manually

make bootstrap again?

Member

hzoo commented Aug 9, 2017

@echo304 ahh http://slack.babeljs.io/ is down 😛 I can invite you manually

make bootstrap again?

@echo304

This comment has been minimized.

Show comment
Hide comment
@echo304

echo304 Aug 9, 2017

Contributor

I've done make bootstrap again but it still couldn't find new plugins...hmmm...it's weird... 🤔
2017-08-10 12 25 25

Contributor

echo304 commented Aug 9, 2017

I've done make bootstrap again but it still couldn't find new plugins...hmmm...it's weird... 🤔
2017-08-10 12 25 25

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Aug 9, 2017

Member

I think I added your email so you can join slack if you didn't see it already

Member

hzoo commented Aug 9, 2017

I think I added your email so you can join slack if you didn't see it already

@hzoo hzoo closed this in #6080 Aug 19, 2017

@lock lock bot added the outdated label May 4, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.