New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In babel-cli add a short log option when compiling #6303

Closed
SamFromDaUk opened this Issue Sep 25, 2017 · 9 comments

Comments

Projects
None yet
7 participants
@SamFromDaUk

SamFromDaUk commented Sep 25, 2017

Choose one: is this a bug report or feature request? feature request

Input Code

N/A

Babel Configuration (.babelrc, package.json, cli command)

{
  "babel-cli": "^6.24.1"
}

node_modules/.bin/babel ./app/src -w -p -d ./app/scripts --modules amd --extensions '.es6,.jsx' --source-maps

Expected Behavior

When compiling a project with a large number of files there can be an excessive amount of logs produced.

The --quiet option removes all logs, however something in between may be of use. Perhaps a x of x files compiled or a percentage based option would be useful?

screen shot 2017-09-25 at 16 31 34

Current Behavior

For large projects either a large amount of logs are shown, or none at all with the --quiet option.

Possible Solution

Add another method of logging the progress of the compiler to show percentage complete or x of x compiled message.

Context

Build step of my project, I can choose between 500+ lines of output or 0.

Your Environment

N/A

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Sep 25, 2017

Collaborator

Hey @SamFromDaUk! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

Collaborator

babel-bot commented Sep 25, 2017

Hey @SamFromDaUk! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@derwaldgeist

This comment has been minimized.

Show comment
Hide comment
@derwaldgeist

derwaldgeist Feb 16, 2018

+1 Would love to see this, too. BTW, this has already been proposed as #1931.

derwaldgeist commented Feb 16, 2018

+1 Would love to see this, too. BTW, this has already been proposed as #1931.

@xtuc xtuc added the pkg: cli label Feb 21, 2018

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Feb 22, 2018

Member

Do we want the files to be logged at all, we could even change the default behavior to not show logs too depends on what we want?

Member

hzoo commented Feb 22, 2018

Do we want the files to be logged at all, we could even change the default behavior to not show logs too depends on what we want?

@derwaldgeist

This comment has been minimized.

Show comment
Hide comment
@derwaldgeist

derwaldgeist Feb 22, 2018

I don't see any reason to log these files. It just clutters up my terminal. If something goes wrong, ok, then please output an error. But otherwise...

derwaldgeist commented Feb 22, 2018

I don't see any reason to log these files. It just clutters up my terminal. If something goes wrong, ok, then please output an error. But otherwise...

@thymikee

This comment has been minimized.

Show comment
Hide comment
@thymikee

thymikee Feb 27, 2018

Contributor

Hey, would something like this ok?

Default:
screen shot 2018-02-27 at 12 38 39

--quiet:
screen shot 2018-02-27 at 12 38 49

Also, on Node >=8 we can easily adjust error message to not include unhelpful stacktrace:
screen shot 2018-02-27 at 12 40 32
(but with or without my changes, the error message on node <=6 is a mess and doesn't tell anything)

Contributor

thymikee commented Feb 27, 2018

Hey, would something like this ok?

Default:
screen shot 2018-02-27 at 12 38 39

--quiet:
screen shot 2018-02-27 at 12 38 49

Also, on Node >=8 we can easily adjust error message to not include unhelpful stacktrace:
screen shot 2018-02-27 at 12 40 32
(but with or without my changes, the error message on node <=6 is a mess and doesn't tell anything)

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism

existentialism Feb 27, 2018

Member

@thymikee thanks for the pr!

Do we want the files to be logged at all, we could even change the default behavior to not show logs too depends on what we want?

Making --quiet the default, and adding --verbose gets a 👍 from me.

Member

existentialism commented Feb 27, 2018

@thymikee thanks for the pr!

Do we want the files to be logged at all, we could even change the default behavior to not show logs too depends on what we want?

Making --quiet the default, and adding --verbose gets a 👍 from me.

@derwaldgeist

This comment has been minimized.

Show comment
Hide comment
@derwaldgeist

derwaldgeist Mar 1, 2018

@existentialism I want to second this. You'd only need the verbose stuff once in a while.

derwaldgeist commented Mar 1, 2018

@existentialism I want to second this. You'd only need the verbose stuff once in a while.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Mar 1, 2018

Member

Yeah this is what I meant in #6303 (comment)

Member

hzoo commented Mar 1, 2018

Yeah this is what I meant in #6303 (comment)

@thymikee

This comment has been minimized.

Show comment
Hide comment
@thymikee

thymikee Mar 1, 2018

Contributor

Ok, I'm happy to update the PR accordingly :)

Contributor

thymikee commented Mar 1, 2018

Ok, I'm happy to update the PR accordingly :)

@Andarist Andarist closed this in #7439 Mar 3, 2018

@lock lock bot added the outdated label Jun 2, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.