New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-redefining helpers broken #6315

Closed
Andarist opened this Issue Sep 26, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@Andarist
Member

Andarist commented Sep 26, 2017

bug report

typeof and extends helpers are designed at the moment in a way that they should redefine themselves (assign to their name's identifier) within their body during first call. This is broken at the moment, because somehow local variable declaration is added in their body (with the same identifier in declarator)

Input Code

Anything using object spread transform.

Babel Configuration (.babelrc, package.json, cli command)

latest babel beta, using latest rollup + appropriate plugin and external-helpers

Expected Behavior

They should redefine themselves.

Current Behavior

Can be observed in this commit. Whole configuration can be also easily checked.

cc @loganfsmyth

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Sep 26, 2017

Collaborator

Hey @Andarist! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

Collaborator

babel-bot commented Sep 26, 2017

Hey @Andarist! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@Andarist Andarist self-assigned this Sep 26, 2017

@Andarist

This comment has been minimized.

Show comment
Hide comment
@Andarist

Andarist Sep 26, 2017

Member

Probably rollup's plugin issue. Gonna head there with a fix

Member

Andarist commented Sep 26, 2017

Probably rollup's plugin issue. Gonna head there with a fix

@Andarist

This comment has been minimized.

Show comment
Hide comment
@Andarist

Andarist Oct 19, 2017

Member

Part of the fix in babel has landed already, closing this in favor of keeping only rollup's PR open.

Member

Andarist commented Oct 19, 2017

Part of the fix in babel has landed already, closing this in favor of keeping only rollup's PR open.

@Andarist Andarist closed this Oct 19, 2017

@worc

This comment has been minimized.

Show comment
Hide comment
@worc

worc Oct 24, 2017

landed where?

edit, looks like it's tagged for babel 7 beta?

worc commented Oct 24, 2017

landed where?

edit, looks like it's tagged for babel 7 beta?

@Andarist

This comment has been minimized.

Show comment
Hide comment
@Andarist

Andarist Oct 24, 2017

Member

@worc, yeah - the issue was about babel 7 beta. It's fixed in babel already, we need still to land rollup/rollup-plugin-babel#170 though. It's usable if you are using npm5 and specify rollup-plugin-babel dep as:

"rollup-plugin-babel": "rollup/rollup-plugin-babel#fix/external-helpers-babel-7"
Member

Andarist commented Oct 24, 2017

@worc, yeah - the issue was about babel 7 beta. It's fixed in babel already, we need still to land rollup/rollup-plugin-babel#170 though. It's usable if you are using npm5 and specify rollup-plugin-babel dep as:

"rollup-plugin-babel": "rollup/rollup-plugin-babel#fix/external-helpers-babel-7"

@lock lock bot added the outdated label May 1, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 1, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.