New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the `.expression` field from `ArrowFunctionExpression` #6773

Closed
loganfsmyth opened this Issue Nov 8, 2017 · 3 comments

Comments

Projects
None yet
4 participants
@loganfsmyth
Member

loganfsmyth commented Nov 8, 2017

Context: #6772 (comment)

As far as I can see, there's no reason to have this flag, so my vote would be to kill it instead of expecting us (and anyone else writing transforms) to remember to always keep it in sync with the type of the body node.

Thoughts?

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth
Member

loganfsmyth commented Nov 8, 2017

@mmckeaveney

This comment has been minimized.

Show comment
Hide comment
@mmckeaveney

mmckeaveney Nov 14, 2017

Contributor

I can pick this up, if that's ok?

Contributor

mmckeaveney commented Nov 14, 2017

I can pick this up, if that's ok?

@Andarist

This comment has been minimized.

Show comment
Hide comment
@Andarist

Andarist Nov 14, 2017

Member

Sure thing. If you have any questions, you can always reach us on Slack.

Member

Andarist commented Nov 14, 2017

Sure thing. If you have any questions, you can always reach us on Slack.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.