New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel-cli to use the async version of babel.transform #6784

Closed
loganfsmyth opened this Issue Nov 9, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@loganfsmyth
Member

loganfsmyth commented Nov 9, 2017

As of #6780, Babel has both babel.transform and babel.transformSync. For backward-compat you can leave the callback off of babel.transform and it'll behave synchronously, but ideally for all the places that can shift to using the async version, they should.

The babel command in babel-cli is one of the places that can easily use the async version. The hard thing will be updating all of the surrounding code to to handle things asynchronously too.

This should be pretty self-contained, so I'm marking it as a good first issue, but it'll definitely involve a good bit of refactoring.

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Nov 9, 2017

Member

I've also filed babel/babel-loader#532, which is the same thing but in babel-loader and probably slightly easier.

Member

loganfsmyth commented Nov 9, 2017

I've also filed babel/babel-loader#532, which is the same thing but in babel-loader and probably slightly easier.

@aprieels

This comment has been minimized.

Show comment
Hide comment
@aprieels

aprieels Nov 12, 2017

Contributor

I'ld like to work on this issue as my first contribution to Babel, if it's ok for you.

Contributor

aprieels commented Nov 12, 2017

I'ld like to work on this issue as my first contribution to Babel, if it's ok for you.

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Nov 12, 2017

Member

@aprieels Go for it. I'd recommend joining our Slack if you haven't, so we can answer any questions you have.

Member

loganfsmyth commented Nov 12, 2017

@aprieels Go for it. I'd recommend joining our Slack if you haven't, so we can answer any questions you have.

@loganfsmyth loganfsmyth added the claimed label Nov 12, 2017

@existentialism existentialism added Has PR and removed help wanted labels Dec 13, 2017

@lock lock bot added the outdated label May 3, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.