New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that inline-elements and constant-elements transforms are unsuitable for development #6813

Open
gaearon opened this Issue Nov 13, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@gaearon
Member

gaearon commented Nov 13, 2017

We keep getting issues in the React repo from people who try to apply inline-elements or constant-elements in development, and then get surprising warnings or false positives. They are not meant for usage in development, but it seems like people miss this information. I wonder if we could highlight it better.

For example, I noticed that:

I would send a PR, but I don't quite understand why the README content on GitHub does not match the website README content.

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism

existentialism Nov 13, 2017

Member

@gaearon definitely confusing, but that blurb of text is actually in the website docs:

https://github.com/babel/website/blob/master/docs/plugins/transform-react-constant-elements.md

Also FYI, the website imports READMEs from the 6.x branch for now, as we have an outstanding task to add version switching. We hope to get this fixed asap =/

Member

existentialism commented Nov 13, 2017

@gaearon definitely confusing, but that blurb of text is actually in the website docs:

https://github.com/babel/website/blob/master/docs/plugins/transform-react-constant-elements.md

Also FYI, the website imports READMEs from the 6.x branch for now, as we have an outstanding task to add version switching. We hope to get this fixed asap =/

@gaearon

This comment has been minimized.

Show comment
Hide comment
@gaearon

gaearon Nov 13, 2017

Member

that blurb of text is actually in the website docs:

I said that in the OP post :-). Two pages mention it, two pages don't.

Member

gaearon commented Nov 13, 2017

that blurb of text is actually in the website docs:

I said that in the OP post :-). Two pages mention it, two pages don't.

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism

existentialism Nov 13, 2017

Member

I don't quite understand why the README content on GitHub does not match the website README content.

Sure, I was actually just validating your confusion :)

I think we should add the warnings to both plugin's README and remove it from the website markdown, no reason for it to be split, IMO.

Member

existentialism commented Nov 13, 2017

I don't quite understand why the README content on GitHub does not match the website README content.

Sure, I was actually just validating your confusion :)

I think we should add the warnings to both plugin's README and remove it from the website markdown, no reason for it to be split, IMO.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Nov 13, 2017

Member

Thanks for the issue 🙂!

yeah @gaearon we don't have versioned docs, that's why it's different because master is 7.x and ya I guess for some reason the docs aren't all contained in the readme

Member

hzoo commented Nov 13, 2017

Thanks for the issue 🙂!

yeah @gaearon we don't have versioned docs, that's why it's different because master is 7.x and ya I guess for some reason the docs aren't all contained in the readme

RusinovAnton added a commit to RusinovAnton/react-select3 that referenced this issue Nov 13, 2017

Remove redundant babel plugins
babel's transform react constant elements and react inline elements are made for production only.
library users may add it themselves if needed.
refs: babel/babel#6813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment