New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: move https://github.com/jridgewell/babel-plugin-transform-for-of-as-array into this repo as an option #6816

Closed
hzoo opened this Issue Nov 13, 2017 · 7 comments

Comments

Projects
None yet
7 participants
@hzoo
Member

hzoo commented Nov 13, 2017

Basically just port/implement this as a plugin option

https://github.com/jridgewell/babel-plugin-transform-for-of-as-array, option name can just be forOfAsArray or some other thing we can bikeshed (buble does dangerousForOf)

cc @jridgewell since you made it?

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell

jridgewell Nov 13, 2017

Member

Sure.

Member

jridgewell commented Nov 13, 2017

Sure.

@rajasekarm

This comment has been minimized.

Show comment
Hide comment
@rajasekarm

rajasekarm Nov 13, 2017

Contributor

I'll pick this

Contributor

rajasekarm commented Nov 13, 2017

I'll pick this

@AkshatSrivastava2

This comment has been minimized.

Show comment
Hide comment
@AkshatSrivastava2

AkshatSrivastava2 Nov 25, 2017

Hello,

I am new to open source.
I want to contribute to babel.
Guide me

AkshatSrivastava2 commented Nov 25, 2017

Hello,

I am new to open source.
I want to contribute to babel.
Guide me

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Nov 25, 2017

Member

@AkshatSrivastava2 Welcome! Take a look at https://github.com/babel/babel/blob/master/CONTRIBUTING.md which should get you started. I believe someone else has already started work on this specific issue though.

Member

loganfsmyth commented Nov 25, 2017

@AkshatSrivastava2 Welcome! Take a look at https://github.com/babel/babel/blob/master/CONTRIBUTING.md which should get you started. I believe someone else has already started work on this specific issue though.

@AkshatSrivastava2

This comment has been minimized.

Show comment
Hide comment
@AkshatSrivastava2

AkshatSrivastava2 Nov 25, 2017

@loganfsmyth Thank you for your response.

AkshatSrivastava2 commented Nov 25, 2017

@loganfsmyth Thank you for your response.

@rajasekarm

This comment has been minimized.

Show comment
Hide comment
@rajasekarm

rajasekarm Nov 27, 2017

Contributor

@AkshatSrivastava2 already working on this. Please pick other issues. Thanks.

Contributor

rajasekarm commented Nov 27, 2017

@AkshatSrivastava2 already working on this. Please pick other issues. Thanks.

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism
Member

existentialism commented Dec 13, 2017

Fixed in #6914

@lock lock bot added the outdated label May 3, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.