Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO: Remove t.jSX* and t.tS* builders aliases #6989

Closed
nicolo-ribaudo opened this issue Dec 7, 2017 · 1 comment
Closed

TODO: Remove t.jSX* and t.tS* builders aliases #6989

nicolo-ribaudo opened this issue Dec 7, 2017 · 1 comment
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types
Milestone

Comments

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 7, 2017

EDIT: make this change on the final release.

#6967 makes the jsx and ts prefixes in node builders lowercase (e.g. t.jsxExpression() instead of t.jSXExpression()).

We can remove the old t.jSX* and *.tS builders. It is a breaking change, but

  1. t.tS* aren't used yet by third party plugins because it has never been in a stable release
  2. There aren't many plugins which build JSX nodes (actually, the only one I could find uses t.JSXIdentifier, so it would't be influenced by this change).

// This is needed for backwards compatibility.
// It should be removed in the next major version.
// JSXIdentifier -> jSXIdentifier
if (/^[A-Z]{2}/.test(type)) {
output += `export { ${type} as ${lowerFirst(type)} }\n`;
}

// This is needed for backwards compatibility.
// It should be removed in the next major version.
// JSXIdentifier -> jSXIdentifier
if (/^[A-Z]{2}/.test(type)) {
output += `export { ${type} as ${lowerFirst(type)} }\n`;
}

@existentialism
Copy link
Member

Fixed in v8 branch via #11095

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types
Projects
None yet
Development

No branches or pull requests

2 participants