New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@babel/generator] Why to keep single quotes behind private APIs? #7138

Closed
avesus opened this Issue Dec 31, 2017 · 5 comments

Comments

Projects
None yet
5 participants
@avesus

avesus commented Dec 31, 2017

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Dec 31, 2017

Collaborator

Hey @avesus! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

Collaborator

babel-bot commented Dec 31, 2017

Hey @avesus! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Dec 31, 2017

Member

We have not historically made any guarantees about formatting in the output code from Babel beyond that it execute the way the spec dictations, and quotes were kind of an odd one where we actually exposed it. If specific formatting is important for you, you could for instance consider running Prettier on the code after it is compiled.

Member

loganfsmyth commented Dec 31, 2017

We have not historically made any guarantees about formatting in the output code from Babel beyond that it execute the way the spec dictations, and quotes were kind of an odd one where we actually exposed it. If specific formatting is important for you, you could for instance consider running Prettier on the code after it is compiled.

@loganfsmyth

This comment has been minimized.

Show comment
Hide comment
@loganfsmyth

loganfsmyth Dec 31, 2017

Member

Made a quick typo there haha, fixed.

Member

loganfsmyth commented Dec 31, 2017

Made a quick typo there haha, fixed.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Dec 31, 2017

Member

Reference issue I made earlier #5139, we decided to remove formatting options because it's a compiled code and didn't seem necessary? It didn't make sense to be a formatter when there are actual options for that like prettier (ideally we could combine the codebases though if that is possible)

Member

hzoo commented Dec 31, 2017

Reference issue I made earlier #5139, we decided to remove formatting options because it's a compiled code and didn't seem necessary? It didn't make sense to be a formatter when there are actual options for that like prettier (ideally we could combine the codebases though if that is possible)

@xtuc

This comment has been minimized.

Show comment
Hide comment
@xtuc

xtuc Jan 3, 2018

Member

@avesus what is your use case?

Note that you can use https://github.com/benjamn/recast with Babel to preserve original formatting.

Member

xtuc commented Jan 3, 2018

@avesus what is your use case?

Note that you can use https://github.com/benjamn/recast with Babel to preserve original formatting.

@loganfsmyth loganfsmyth closed this Mar 5, 2018

@lock lock bot added the outdated label Jun 4, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.