New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@babel/types BaseComment type not match @babel/parser output #8969

Closed
wulunyi opened this Issue Nov 4, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@wulunyi

wulunyi commented Nov 4, 2018

@babel/types/lib/index.d.ts

interface BaseComment {
  value: string;
  start: number;
  end: number;
  loc: SourceLocation;
  type: "BlockComment" | "LineComment";
}

export interface BlockComment extends BaseComment {
  type: "BlockComment";
}

export interface LineComment extends BaseComment {
  type: "LineComment";
}

https://astexplorer.net/ result
image

image

@babel-bot

This comment has been minimized.

Collaborator

babel-bot commented Nov 4, 2018

Hey @wulunyi! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community that typically always has someone willing to help. You can sign-up here
for an invite.

@alexsilvar

This comment has been minimized.

alexsilvar commented Nov 8, 2018

Hello, which is the expected output, "BlockComment" ? (please, tell which version of Babel are you using at astexplorer)

@wulunyi

This comment has been minimized.

wulunyi commented Nov 9, 2018

I expect the @babel/types .d.ts comment declaration match the @babel/parser output.

@babel/parser version 7.1.0
The parser output comment node type "CommentBlock"
@babel/types version 7.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment