New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: TypeScript: Parse error on abstract class with abstract method and optional methods in abstract/declare classes. #9305

Open
armano2 opened this Issue Jan 9, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@armano2
Copy link
Contributor

armano2 commented Jan 9, 2019

Bug Report

Current Behavior
Babel expect that abstract methods must have body, this is not a case for typescript.
This is also issue for optional methods in abstract/declare classes.

SyntaxError: Unexpected token, expected "{"

Input Code

abstract class AbstractSocket {
    abstract createSocket(): Promise<string>;
}
abstract class AbstractSocket {
    createSocket?(): Promise<string>;
}
declare class Foo {
    bar?(): any;
}

Expected behavior/code
There should not be any parse errors

Babel Configuration (.babelrc, package.json, cli command)

  const babel = require('@babel/parser');
  const plugins: ParserPlugin[] = [
    'typescript',
    'objectRestSpread',
    'decorators-legacy',
    'classProperties',
    'asyncGenerators',
    'dynamicImport',
    'estree',
    'bigInt',
    'importMeta'
  ];
  if (jsx) {
    plugins.push('jsx');
  }

  return babel.parse(text, {
    sourceType: 'unambiguous',
    allowImportExportEverywhere: true,
    allowReturnOutsideFunction: true,
    ranges: true,
    plugins
  });

Environment

  • Babel version(s): 7.2.3
  • Node/npm version: 6-11
  • OS: ----
  • Monorepo: ---
  • How you are using Babel: @babel/parser -> parse
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jan 9, 2019

Hey @armano2! We really appreciate you taking the time to report an issue. The collaborators
on this project attempt to help as many people as possible, but we're a limited number of volunteers,
so it's possible this won't be addressed swiftly.

If you need any help, or just have general Babel or JavaScript questions, we have a vibrant Slack
community
that typically always has someone willing to help. You can sign-up here
for an invite.

@armano2 armano2 changed the title @babel/parser(ts): Parse error on abstract class with abstract method. @babel/parser(ts): Parse error on abstract class with abstract method and optional methods in abstract/declare. Jan 9, 2019

@armano2 armano2 changed the title @babel/parser(ts): Parse error on abstract class with abstract method and optional methods in abstract/declare. @babel/parser(ts): Parse error on abstract class with abstract method and optional methods in abstract/declare classes. Jan 9, 2019

@armano2 armano2 changed the title @babel/parser(ts): Parse error on abstract class with abstract method and optional methods in abstract/declare classes. parser: TypeScript: Parse error on abstract class with abstract method and optional methods in abstract/declare classes. Jan 15, 2019

@armano2

This comment has been minimized.

Copy link
Contributor

armano2 commented Jan 19, 2019

@existentialism is it something what we want to support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment